| Message ID | 20240507-samsung-usb-phy-fixes-v1-4-4ccba5afa7cc@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | a few fixes for the Samsung USB phy driver | expand |
Hi André, On Tue, 7 May 2024 at 15:14, André Draszik <andre.draszik@linaro.org> wrote: > > Using 0x82 seems odd, where everything else is just a sequence. > > On E850, this macro isn't used (as a register value), only to assign > its value to the 'extrefclk' variable, which is otherwise unused on > that platform. Older platforms don't appear to support 26MHz in the > first place (since this macro was added for E850). > > Furthermore, the downstream driver uses 0x82 to denote > USBPHY_REFCLK_DIFF_26MHZ (whatever that means exactly), but for all the > other values we match downstream's non-DIFF macros. > > Update to avoid confusion. No functional change intended. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Peter Griffin <peter.griffin@linaro.org> regards, Peter [..]
diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index ed4898741c99..1da7a4881f72 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -30,7 +30,7 @@ #define EXYNOS5_FSEL_19MHZ2 0x3 #define EXYNOS5_FSEL_20MHZ 0x4 #define EXYNOS5_FSEL_24MHZ 0x5 -#define EXYNOS5_FSEL_26MHZ 0x82 +#define EXYNOS5_FSEL_26MHZ 0x6 #define EXYNOS5_FSEL_50MHZ 0x7 /* Exynos5: USB 3.0 DRD PHY registers */
Using 0x82 seems odd, where everything else is just a sequence. On E850, this macro isn't used (as a register value), only to assign its value to the 'extrefclk' variable, which is otherwise unused on that platform. Older platforms don't appear to support 26MHz in the first place (since this macro was added for E850). Furthermore, the downstream driver uses 0x82 to denote USBPHY_REFCLK_DIFF_26MHZ (whatever that means exactly), but for all the other values we match downstream's non-DIFF macros. Update to avoid confusion. No functional change intended. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)