diff mbox series

[RFT,1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags

Message ID 20240605160032.150587-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit d044c0e36d095996f7b29a928e06c9475c4075e6
Headers show
Series [RFT,1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags | expand

Commit Message

Krzysztof Kozlowski June 5, 2024, 4 p.m. UTC
Interrupt flags 0x2008 looks like some downstream copy-paste, because
generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
flags outside of IRQ_TYPE_SENSE_MASK.  Probably the intention was to
pass just 0x8, so IRQ_TYPE_LEVEL_LOW.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio June 6, 2024, 10:18 a.m. UTC | #1
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK.  Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Konrad Dybcio June 6, 2024, 10:18 a.m. UTC | #2
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK.  Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Konrad Dybcio June 6, 2024, 10:19 a.m. UTC | #3
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK.  Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

I only tested on one 8450 device, but they're all:
- the same tlmm
- the same geni
- the same touchscreen

so I suppose it's alright

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8450 PDX223

Konrad
Bjorn Andersson June 7, 2024, 2:33 a.m. UTC | #4
On Wed, 05 Jun 2024 18:00:29 +0200, Krzysztof Kozlowski wrote:
> Interrupt flags 0x2008 looks like some downstream copy-paste, because
> generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores
> flags outside of IRQ_TYPE_SENSE_MASK.  Probably the intention was to
> pass just 0x8, so IRQ_TYPE_LEVEL_LOW.
> 
> 

Applied, thanks!

[1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags
      commit: d044c0e36d095996f7b29a928e06c9475c4075e6
[2/4] arm64: dts: qcom: sm6375-pdx225: correct touchscreen interrupt flags
      commit: fa2c8cad202195bfa87b18dc44ff4981d45085b4
[3/4] arm64: dts: qcom: sm8250-sony-xperia: correct touchscreen interrupt flags
      commit: 46822d2750822dbe58bcd999cbedf24147cb5fc3
[4/4] arm64: dts: qcom: sm8450-sony-xperia: correct touchscreen interrupt flags
      commit: 05d84f973d84d23e0a249ae5b3f6d7572fdc5e1e

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 88ee04973a2f..bf23033a294e 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -293,7 +293,7 @@  touchscreen@48 {
 		compatible = "samsung,s6sy761";
 		reg = <0x48>;
 		interrupt-parent = <&tlmm>;
-		interrupts = <22 0x2008>;
+		interrupts = <22 IRQ_TYPE_LEVEL_LOW>;
 		vdd-supply = <&pm6350_l11>;
 		avdd-supply = <&touch_en_vreg>;