mbox series

[v2,0/3] semihosting: Restrict to TCG

Message ID 20240530145349.41309-1-philmd@linaro.org
Headers show
Series semihosting: Restrict to TCG | expand

Message

Philippe Mathieu-Daudé May 30, 2024, 2:53 p.m. UTC 
v2: Address Paolo's comment

Semihosting currently uses the TCG probe_access API,
so it is pointless to have it in the binary when TCG
isn't.

It could be implemented for other accelerators, but
work need to be done. Meanwhile, do not enable it
unless TCG is available.

Philippe Mathieu-Daudé (3):
  target/mips: Restrict semihosting to TCG
  target/riscv: Restrict semihosting to TCG
  semihosting: Restrict to TCG

 semihosting/Kconfig  | 1 +
 target/mips/Kconfig  | 2 +-
 target/riscv/Kconfig | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

Comments

Philippe Mathieu-Daudé June 3, 2024, 8:27 a.m. UTC | #1 
On 30/5/24 16:53, Philippe Mathieu-Daudé wrote:
> v2: Address Paolo's comment

Missing review: 1 & 2

> Semihosting currently uses the TCG probe_access API,
> so it is pointless to have it in the binary when TCG
> isn't.
> 
> It could be implemented for other accelerators, but
> work need to be done. Meanwhile, do not enable it
> unless TCG is available.
> 
> Philippe Mathieu-Daudé (3):
>    target/mips: Restrict semihosting to TCG
>    target/riscv: Restrict semihosting to TCG
>    semihosting: Restrict to TCG
> 
>   semihosting/Kconfig  | 1 +
>   target/mips/Kconfig  | 2 +-
>   target/riscv/Kconfig | 4 ++--
>   3 files changed, 4 insertions(+), 3 deletions(-)
>
Philippe Mathieu-Daudé June 6, 2024, 12:43 p.m. UTC | #2 
Kind ping :)

On 3/6/24 10:27, Philippe Mathieu-Daudé wrote:
> On 30/5/24 16:53, Philippe Mathieu-Daudé wrote:
>> v2: Address Paolo's comment
> 
> Missing review: 1 & 2
> 
>> Semihosting currently uses the TCG probe_access API,
>> so it is pointless to have it in the binary when TCG
>> isn't.
>>
>> It could be implemented for other accelerators, but
>> work need to be done. Meanwhile, do not enable it
>> unless TCG is available.
>>
>> Philippe Mathieu-Daudé (3):
>>    target/mips: Restrict semihosting to TCG
>>    target/riscv: Restrict semihosting to TCG
>>    semihosting: Restrict to TCG
>>
>>   semihosting/Kconfig  | 1 +
>>   target/mips/Kconfig  | 2 +-
>>   target/riscv/Kconfig | 4 ++--
>>   3 files changed, 4 insertions(+), 3 deletions(-)
>>
>
Anton Johansson June 6, 2024, 1:42 p.m. UTC | #3 
On 06/06/24, Philippe Mathieu-Daudé wrote:
> Kind ping :)

I'm off today, I'll take a look tomorrow morning!:)
//Anton