diff mbox series

scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

Message ID 20240528215640.91771-1-linux@treblig.org
State New
Headers show
Series scsi: qla2xxx: remove unused struct 'scsi_dif_tuple' | expand

Commit Message

Dr. David Alan Gilbert May 28, 2024, 9:56 p.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'scsi_dif_tuple' is unused since
commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
sectors.").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/scsi/qla2xxx/qla_isr.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Himanshu Madhani May 29, 2024, 6:58 p.m. UTC | #1 
On 5/28/24 14:56, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   drivers/scsi/qla2xxx/qla_isr.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index d48007e18288..fe98c76e9be3 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
>   	}
>   }
>   
> -struct scsi_dif_tuple {
> -	__be16 guard;       /* Checksum */
> -	__be16 app_tag;         /* APPL identifier */
> -	__be32 ref_tag;         /* Target LBA or indirect LBA */
> -};
> -
>   /*
>    * Checks the guard or meta-data for the type of error
>    * detected by the HBA. In case of errors, we set the

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Martin K. Petersen May 31, 2024, 12:27 a.m. UTC | #2 
> 'scsi_dif_tuple' is unused since commit 8cb2049c7448 ("[SCSI] qla2xxx:
> T10 DIF - Handle uninitalized sectors.").
>
> Remove it.

Applied to 6.11/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index d48007e18288..fe98c76e9be3 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -3014,12 +3014,6 @@  qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
 	}
 }
 
-struct scsi_dif_tuple {
-	__be16 guard;       /* Checksum */
-	__be16 app_tag;         /* APPL identifier */
-	__be32 ref_tag;         /* Target LBA or indirect LBA */
-};
-
 /*
  * Checks the guard or meta-data for the type of error
  * detected by the HBA. In case of errors, we set the