| Message ID | 878qzt4hkk.wl-kuninori.morimoto.gx@renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | use for_each_endpoint_of_node() | expand |
Hi Morimoto-san, Thank you for the patch. On Tue, May 28, 2024 at 11:55:55PM +0000, Kuninori Morimoto wrote: > We already have for_each_endpoint_of_node(), don't use > of_graph_get_next_endpoint() directly. Replace it. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c > index 09f719af0d0c9..d80720c843235 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c > @@ -149,8 +149,7 @@ static void __init omapdss_walk_device(struct device_node *node, bool root) > > of_node_put(n); > > - n = NULL; > - while ((n = of_graph_get_next_endpoint(node, n)) != NULL) { > + for_each_endpoint_of_node(node, n) { > struct device_node *pn; > > pn = of_graph_get_remote_port_parent(n);
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c index 09f719af0d0c9..d80720c843235 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c @@ -149,8 +149,7 @@ static void __init omapdss_walk_device(struct device_node *node, bool root) of_node_put(n); - n = NULL; - while ((n = of_graph_get_next_endpoint(node, n)) != NULL) { + for_each_endpoint_of_node(node, n) { struct device_node *pn; pn = of_graph_get_remote_port_parent(n);
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)