| Message ID | 20240517061713.95803-2-hal.feng@starfivetech.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add the core reset for UARTs of StarFive JH7110 | expand |
On Fri, May 17, 2024 at 02:17:11PM +0800, Hal Feng wrote: > The UART of StarFive JH7110 has two reset signals. > Both of them are necessary for JH7110 to initialize UART. > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > --- > .../bindings/serial/snps-dw-apb-uart.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > index 1001d2a6ace8..a6396c5cbfb1 100644 > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > @@ -13,6 +13,16 @@ allOf: > - $ref: serial.yaml# > - $ref: rs485.yaml# > > + - if: > + properties: > + compatible: > + contains: > + const: starfive,jh7110-uart > + then: > + properties: > + resets: > + minItems: 2 else: properties: resets: maxItems: 1 Thanks, Conor. > + > properties: > compatible: > oneOf: > @@ -48,6 +58,7 @@ properties: > - enum: > - starfive,jh7100-hsuart > - starfive,jh7100-uart > + - starfive,jh7110-uart > - const: snps,dw-apb-uart > - const: snps,dw-apb-uart > > @@ -82,7 +93,8 @@ properties: > type: boolean > > resets: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > > reg-shift: true > > -- > 2.43.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
> On 18.05.24 00:17, Conor Dooley wrote: > On Fri, May 17, 2024 at 02:17:11PM +0800, Hal Feng wrote: > > The UART of StarFive JH7110 has two reset signals. > > Both of them are necessary for JH7110 to initialize UART. > > > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > --- > > .../bindings/serial/snps-dw-apb-uart.yaml | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > index 1001d2a6ace8..a6396c5cbfb1 100644 > > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > @@ -13,6 +13,16 @@ allOf: > > - $ref: serial.yaml# > > - $ref: rs485.yaml# > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: starfive,jh7110-uart > > + then: > > + properties: > > + resets: > > + minItems: 2 > > else: > properties: > resets: > maxItems: 1 Will fix it later. Thanks for your review. Best regards, Hal
diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml index 1001d2a6ace8..a6396c5cbfb1 100644 --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml @@ -13,6 +13,16 @@ allOf: - $ref: serial.yaml# - $ref: rs485.yaml# + - if: + properties: + compatible: + contains: + const: starfive,jh7110-uart + then: + properties: + resets: + minItems: 2 + properties: compatible: oneOf: @@ -48,6 +58,7 @@ properties: - enum: - starfive,jh7100-hsuart - starfive,jh7100-uart + - starfive,jh7110-uart - const: snps,dw-apb-uart - const: snps,dw-apb-uart @@ -82,7 +93,8 @@ properties: type: boolean resets: - maxItems: 1 + minItems: 1 + maxItems: 2 reg-shift: true
The UART of StarFive JH7110 has two reset signals. Both of them are necessary for JH7110 to initialize UART. Signed-off-by: Hal Feng <hal.feng@starfivetech.com> --- .../bindings/serial/snps-dw-apb-uart.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)