| Message ID | 67ac1063406f022ccc35b94ba41317b6e9ee8b3e.1716393035.git.jerome.forissier@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce the lwIP network stack | expand |
On Wed, May 22, 2024 at 06:00:12PM +0200, Jerome Forissier wrote: > Add qemu_arm64_lwip_defconfig which was created from > qemu_arm64_defconfig with CONFIG_NET_LWIP enabled. > > Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> > --- > configs/qemu_arm64_lwip_defconfig | 70 +++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 configs/qemu_arm64_lwip_defconfig > > diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig > new file mode 100644 > index 0000000000..c8dadbce37 > --- /dev/null > +++ b/configs/qemu_arm64_lwip_defconfig > @@ -0,0 +1,70 @@ > +CONFIG_ARM=y > +CONFIG_POSITION_INDEPENDENT=y > +CONFIG_ARCH_QEMU=y Setting aside that I would like lwip to default to y, at least in the first few iterations (so that testing is easier), this should be using the #include method rather than duplicating the whole config.
On 5/23/24 17:02, Tom Rini wrote: > On Wed, May 22, 2024 at 06:00:12PM +0200, Jerome Forissier wrote: > >> Add qemu_arm64_lwip_defconfig which was created from >> qemu_arm64_defconfig with CONFIG_NET_LWIP enabled. >> >> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> >> --- >> configs/qemu_arm64_lwip_defconfig | 70 +++++++++++++++++++++++++++++++ >> 1 file changed, 70 insertions(+) >> create mode 100644 configs/qemu_arm64_lwip_defconfig >> >> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig >> new file mode 100644 >> index 0000000000..c8dadbce37 >> --- /dev/null >> +++ b/configs/qemu_arm64_lwip_defconfig >> @@ -0,0 +1,70 @@ >> +CONFIG_ARM=y >> +CONFIG_POSITION_INDEPENDENT=y >> +CONFIG_ARCH_QEMU=y > > Setting aside that I would like lwip to default to y, at least in the > first few iterations (so that testing is easier), I could certainly do this. By creating a new defconfig, my goal was to minimize the impacts on existing use cases. > this should be using > the #include method rather than duplicating the whole config. I've done that for v2. Let me know if you still prefer I change qemu_arm64_defconfig instead. Thanks,
On Fri, May 24, 2024 at 12:09:33PM +0200, Jerome Forissier wrote: > > > On 5/23/24 17:02, Tom Rini wrote: > > On Wed, May 22, 2024 at 06:00:12PM +0200, Jerome Forissier wrote: > > > >> Add qemu_arm64_lwip_defconfig which was created from > >> qemu_arm64_defconfig with CONFIG_NET_LWIP enabled. > >> > >> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> > >> --- > >> configs/qemu_arm64_lwip_defconfig | 70 +++++++++++++++++++++++++++++++ > >> 1 file changed, 70 insertions(+) > >> create mode 100644 configs/qemu_arm64_lwip_defconfig > >> > >> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig > >> new file mode 100644 > >> index 0000000000..c8dadbce37 > >> --- /dev/null > >> +++ b/configs/qemu_arm64_lwip_defconfig > >> @@ -0,0 +1,70 @@ > >> +CONFIG_ARM=y > >> +CONFIG_POSITION_INDEPENDENT=y > >> +CONFIG_ARCH_QEMU=y > > > > Setting aside that I would like lwip to default to y, at least in the > > first few iterations (so that testing is easier), > > I could certainly do this. By creating a new defconfig, my goal was to > minimize the impacts on existing use cases. Yes but then it makes it harder to out of the box see what the deltas are. > > this should be using > > the #include method rather than duplicating the whole config. > > I've done that for v2. Let me know if you still prefer I change > qemu_arm64_defconfig instead. This is fine for v2, yeah. Once that's posted I'll grab everything and: - Throw it at the small HW lab I have - Enable it by default for everyone and throw it at CI - Also throw it at my script for world build before/after and using buildman's bloat checker to see what grew how much where.
On 5/24/24 17:08, Tom Rini wrote: > On Fri, May 24, 2024 at 12:09:33PM +0200, Jerome Forissier wrote: >> >> >> On 5/23/24 17:02, Tom Rini wrote: >>> On Wed, May 22, 2024 at 06:00:12PM +0200, Jerome Forissier wrote: >>> >>>> Add qemu_arm64_lwip_defconfig which was created from >>>> qemu_arm64_defconfig with CONFIG_NET_LWIP enabled. >>>> >>>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> >>>> --- >>>> configs/qemu_arm64_lwip_defconfig | 70 +++++++++++++++++++++++++++++++ >>>> 1 file changed, 70 insertions(+) >>>> create mode 100644 configs/qemu_arm64_lwip_defconfig >>>> >>>> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig >>>> new file mode 100644 >>>> index 0000000000..c8dadbce37 >>>> --- /dev/null >>>> +++ b/configs/qemu_arm64_lwip_defconfig >>>> @@ -0,0 +1,70 @@ >>>> +CONFIG_ARM=y >>>> +CONFIG_POSITION_INDEPENDENT=y >>>> +CONFIG_ARCH_QEMU=y >>> >>> Setting aside that I would like lwip to default to y, at least in the >>> first few iterations (so that testing is easier), >> >> I could certainly do this. By creating a new defconfig, my goal was to >> minimize the impacts on existing use cases. > > Yes but then it makes it harder to out of the box see what the deltas > are. > >>> this should be using >>> the #include method rather than duplicating the whole config. >> >> I've done that for v2. Let me know if you still prefer I change >> qemu_arm64_defconfig instead. > > This is fine for v2, yeah. Once that's posted I'll grab everything and: > - Throw it at the small HW lab I have > - Enable it by default for everyone and throw it at CI At this point you can expect quite a few failures (unresolved symbols to begin with) because so many parts of the network-related code peek & poke various parts of the net implementation without formally depending on NET (i.e., !NET_LWIP). Some more work is clearly needed to port to lwIP, how much is probably something the CI run will help understand. Thanks,
On Fri, May 24, 2024 at 05:30:45PM +0200, Jerome Forissier wrote: > > > On 5/24/24 17:08, Tom Rini wrote: > > On Fri, May 24, 2024 at 12:09:33PM +0200, Jerome Forissier wrote: > >> > >> > >> On 5/23/24 17:02, Tom Rini wrote: > >>> On Wed, May 22, 2024 at 06:00:12PM +0200, Jerome Forissier wrote: > >>> > >>>> Add qemu_arm64_lwip_defconfig which was created from > >>>> qemu_arm64_defconfig with CONFIG_NET_LWIP enabled. > >>>> > >>>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> > >>>> --- > >>>> configs/qemu_arm64_lwip_defconfig | 70 +++++++++++++++++++++++++++++++ > >>>> 1 file changed, 70 insertions(+) > >>>> create mode 100644 configs/qemu_arm64_lwip_defconfig > >>>> > >>>> diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig > >>>> new file mode 100644 > >>>> index 0000000000..c8dadbce37 > >>>> --- /dev/null > >>>> +++ b/configs/qemu_arm64_lwip_defconfig > >>>> @@ -0,0 +1,70 @@ > >>>> +CONFIG_ARM=y > >>>> +CONFIG_POSITION_INDEPENDENT=y > >>>> +CONFIG_ARCH_QEMU=y > >>> > >>> Setting aside that I would like lwip to default to y, at least in the > >>> first few iterations (so that testing is easier), > >> > >> I could certainly do this. By creating a new defconfig, my goal was to > >> minimize the impacts on existing use cases. > > > > Yes but then it makes it harder to out of the box see what the deltas > > are. > > > >>> this should be using > >>> the #include method rather than duplicating the whole config. > >> > >> I've done that for v2. Let me know if you still prefer I change > >> qemu_arm64_defconfig instead. > > > > This is fine for v2, yeah. Once that's posted I'll grab everything and: > > - Throw it at the small HW lab I have > > - Enable it by default for everyone and throw it at CI > > At this point you can expect quite a few failures (unresolved symbols to > begin with) because so many parts of the network-related code peek & poke > various parts of the net implementation without formally depending on NET > (i.e., !NET_LWIP). Some more work is clearly needed to port to lwIP, how > much is probably something the CI run will help understand. OK, thanks for setting expectations. And FYI if you hadn't seen: https://docs.u-boot.org/en/latest/develop/ci_testing.html you can trigger them yourself, but Azure sometimes just has issues if we get a slow runner sometimes.
diff --git a/configs/qemu_arm64_lwip_defconfig b/configs/qemu_arm64_lwip_defconfig new file mode 100644 index 0000000000..c8dadbce37 --- /dev/null +++ b/configs/qemu_arm64_lwip_defconfig @@ -0,0 +1,70 @@ +CONFIG_ARM=y +CONFIG_POSITION_INDEPENDENT=y +CONFIG_ARCH_QEMU=y +CONFIG_SYS_MALLOC_LEN=0x1000000 +CONFIG_NR_DRAM_BANKS=1 +CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x40200000 +CONFIG_ENV_SIZE=0x40000 +CONFIG_ENV_SECT_SIZE=0x40000 +CONFIG_DEFAULT_DEVICE_TREE="qemu-arm64" +CONFIG_DEBUG_UART_BASE=0x9000000 +CONFIG_DEBUG_UART_CLOCK=0 +CONFIG_ARMV8_CRYPTO=y +CONFIG_SYS_LOAD_ADDR=0x40200000 +CONFIG_ENV_ADDR=0x4000000 +CONFIG_PCI=y +CONFIG_DEBUG_UART=y +CONFIG_AHCI=y +CONFIG_FIT=y +CONFIG_FIT_SIGNATURE=y +CONFIG_FIT_VERBOSE=y +CONFIG_FIT_BEST_MATCH=y +CONFIG_BOOTSTD_FULL=y +CONFIG_LEGACY_IMAGE_FORMAT=y +CONFIG_USE_PREBOOT=y +# CONFIG_DISPLAY_CPUINFO is not set +# CONFIG_DISPLAY_BOARDINFO is not set +CONFIG_PCI_INIT_R=y +CONFIG_CMD_SMBIOS=y +CONFIG_CMD_BOOTZ=y +CONFIG_CMD_BOOTEFI_SELFTEST=y +CONFIG_CMD_NVEDIT_EFI=y +CONFIG_CMD_DFU=y +CONFIG_CMD_MTD=y +CONFIG_CMD_PCI=y +CONFIG_CMD_TPM=y +CONFIG_CMD_MTDPARTS=y +CONFIG_ENV_IS_IN_FLASH=y +CONFIG_NET_LWIP=y +CONFIG_SCSI_AHCI=y +CONFIG_AHCI_PCI=y +CONFIG_DFU_MTD=y +CONFIG_DFU_RAM=y +# CONFIG_MMC is not set +CONFIG_MTD=y +CONFIG_DM_MTD=y +CONFIG_MTD_NOR_FLASH=y +CONFIG_FLASH_SHOW_PROGRESS=0 +CONFIG_CFI_FLASH=y +CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS=y +CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y +CONFIG_FLASH_CFI_MTD=y +CONFIG_SYS_FLASH_CFI=y +CONFIG_SYS_MAX_FLASH_SECT=256 +CONFIG_SYS_MAX_FLASH_BANKS=2 +CONFIG_SYS_MAX_FLASH_BANKS_DETECT=y +CONFIG_E1000=y +CONFIG_NVME_PCI=y +CONFIG_PCIE_ECAM_GENERIC=y +CONFIG_SCSI=y +CONFIG_DEBUG_UART_PL011=y +CONFIG_DEBUG_UART_SHIFT=2 +CONFIG_SYSRESET=y +CONFIG_SYSRESET_CMD_POWEROFF=y +CONFIG_SYSRESET_PSCI=y +CONFIG_TPM2_MMIO=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_PCI=y +CONFIG_SEMIHOSTING=y +CONFIG_TPM=y
Add qemu_arm64_lwip_defconfig which was created from qemu_arm64_defconfig with CONFIG_NET_LWIP enabled. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> --- configs/qemu_arm64_lwip_defconfig | 70 +++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 configs/qemu_arm64_lwip_defconfig