| Message ID | 20240509001138.204427-1-linux@treblig.org |
|---|---|
| State | Accepted |
| Commit | 04e83604f5857d1762f8c04e9d0fbd0b11839a89 |
| Headers | show |
| Series | Bluetooth/nokia: Remove unused struct 'hci_nokia_radio_hdr' | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=851727 ---Test result--- Test Summary: CheckPatch PASS 0.63 seconds GitLint PASS 0.32 seconds SubjectPrefix FAIL 0.31 seconds BuildKernel PASS 29.81 seconds CheckAllWarning PASS 32.29 seconds CheckSparse WARNING 37.72 seconds CheckSmatch FAIL 35.62 seconds BuildKernel32 PASS 28.50 seconds TestRunnerSetup PASS 516.77 seconds TestRunner_l2cap-tester PASS 20.34 seconds TestRunner_iso-tester PASS 30.71 seconds TestRunner_bnep-tester PASS 4.67 seconds TestRunner_mgmt-tester PASS 108.31 seconds TestRunner_rfcomm-tester PASS 7.31 seconds TestRunner_sco-tester PASS 14.94 seconds TestRunner_ioctl-tester PASS 7.61 seconds TestRunner_mesh-tester PASS 5.76 seconds TestRunner_smp-tester PASS 6.75 seconds TestRunner_userchan-tester PASS 4.88 seconds IncrementalBuild PASS 28.45 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: CheckSparse - WARNING Desc: Run sparse tool with linux kernel Output: drivers/bluetooth/hci_nokia.c:279:23: warning: incorrect type in assignment (different base types)drivers/bluetooth/hci_nokia.c:279:23: expected unsigned short [usertype] bauddrivers/bluetooth/hci_nokia.c:279:23: got restricted __le16 [usertype]drivers/bluetooth/hci_nokia.c:282:26: warning: incorrect type in assignment (different base types)drivers/bluetooth/hci_nokia.c:282:26: expected unsigned short [usertype] sys_clkdrivers/bluetooth/hci_nokia.c:282:26: got restricted __le16 [usertype] ############################## Test: CheckSmatch - FAIL Desc: Run smatch tool with source Output: Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139 make[4]: *** Deleting file 'net/bluetooth/hci_core.o' make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: net] Error 2 make[2]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o' make[4]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o' make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: drivers] Error 2 make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2 make: *** [Makefile:240: __sub-make] Error 2 --- Regards, Linux Bluetooth
* linux@treblig.org (linux@treblig.org) wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'hci_nokia_radio_hdr' looks like it was unused since it's > initial commit. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Ping? I see a message from the bot asking for a change to the header which I think wants Bluetooth: nokia: ? (But then a load of segfaults in the test scripts). Anything else? Dave > --- > drivers/bluetooth/hci_nokia.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c > index 97da0b2bfd17e..62633d9ba7c43 100644 > --- a/drivers/bluetooth/hci_nokia.c > +++ b/drivers/bluetooth/hci_nokia.c > @@ -116,11 +116,6 @@ struct hci_nokia_neg_evt { > #define SETUP_BAUD_RATE 921600 > #define INIT_BAUD_RATE 120000 > > -struct hci_nokia_radio_hdr { > - u8 evt; > - u8 dlen; > -} __packed; > - > struct nokia_bt_dev { > struct hci_uart hu; > struct serdev_device *serdev; > -- > 2.45.0 >
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 9 May 2024 01:11:38 +0100 you wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'hci_nokia_radio_hdr' looks like it was unused since it's > initial commit. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > [...] Here is the summary with links: - Bluetooth/nokia: Remove unused struct 'hci_nokia_radio_hdr' https://git.kernel.org/bluetooth/bluetooth-next/c/04e83604f585 You are awesome, thank you!
diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c index 97da0b2bfd17e..62633d9ba7c43 100644 --- a/drivers/bluetooth/hci_nokia.c +++ b/drivers/bluetooth/hci_nokia.c @@ -116,11 +116,6 @@ struct hci_nokia_neg_evt { #define SETUP_BAUD_RATE 921600 #define INIT_BAUD_RATE 120000 -struct hci_nokia_radio_hdr { - u8 evt; - u8 dlen; -} __packed; - struct nokia_bt_dev { struct hci_uart hu; struct serdev_device *serdev;