| Message ID | 20240517194246.747427-1-andriy.shevchenko@linux.intel.com |
|---|---|
| Headers | show |
| Series | spi: gpio: Convert to be used outside of OF | expand |
On Fri, May 17, 2024 at 10:42:03PM +0300, Andy Shevchenko wrote: > There is no use for whole 16-bit for the number of chip select pins. > Drop it to 8 bits. because...? It's the only field in the struct so it's not like it makes any meaningful different to struct layout.
On Mon, May 20, 2024 at 12:28:12PM +0300, Andy Shevchenko wrote: > On Fri, May 17, 2024 at 10:55:55PM +0100, Mark Brown wrote: > > On Fri, May 17, 2024 at 10:42:03PM +0300, Andy Shevchenko wrote: > > > There is no use for whole 16-bit for the number of chip select pins. > > > Drop it to 8 bits. > > > > because...? > > To make the type stricter, but since there is no other benefits and > this one likely won't help to catch the (incorrect) use of big numbers > I think we don't need it. > > > It's the only field in the struct so it's not like it makes > > any meaningful different to struct layout. Should I do something about the first two patches or is it fine to get them in?
Convert the driver to be used outside of OF and a couple of cleanups. Andy Shevchenko (3): spi: gpio: Make use of device properties spi: gpio: Use traditional pattern when checking error codes spi: gpio: Make num_chipselect 8-bit in the struct spi_gpio_platform_data drivers/spi/spi-gpio.c | 66 ++++++++++++++---------------------- include/linux/spi/spi_gpio.h | 2 +- 2 files changed, 26 insertions(+), 42 deletions(-)