mbox series

[v2,0/5] input: himax_hx83112b: add support for HX83100A

Message ID 20240511121245.109644-1-felix@kaechele.ca
Headers show
Series input: himax_hx83112b: add support for HX83100A | expand

Message

Felix Kaechele May 11, 2024, 12:12 p.m. UTC 
Resent, due to being caught in the spam filter.

This set of patches brings support for the Himax HX83100A touch
controller.

I have no access to datasheets. So, like the original driver code
that's being extended here, this code is mostly based on the quite
convoluted, GPLv2 licensed manufacturer drivers for Android.
I included links to sources and references where appropriate.

A number of people tested this patch set on Lenovo ThinkSmart View
(CD-18781Y) devices. That device has a variant utilizing a Innolux
P080DDD-AB2 LCM. This LCM comes with the HX83100A.

I would really appreciate if people using HX83112B chips could give this
set a run to ensure nothing broke.

Thanks,
Felix

Changes in v2:
- removed regulator handling, my test device works fine without it
- some minor formatting fixes

Felix Kaechele (5):
  dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A
  input: himax_hx83112b: use more descriptive register defines
  input: himax_hx83112b: implement MCU register reading
  input: himax_hx83112b: add himax_chip struct for multi-chip support
  input: himax_hx83112b: add support for HX83100A

 .../input/touchscreen/himax,hx83112b.yaml     |   1 +
 drivers/input/touchscreen/himax_hx83112b.c    | 135 ++++++++++++++----
 2 files changed, 110 insertions(+), 26 deletions(-)


base-commit: 5128de84d8fc849400d00f7a6982711f129699ea

Comments

Felix Kaechele May 11, 2024, 2:10 p.m. UTC | #1 
On 2024-05-11 08:38, Conor Dooley wrote:
> On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
>> Add a compatible string for the Himax HX83100A touch controller.
>>
>> Signed-off-by: Felix Kaechele <felix@kaechele.ca>
> 
> Commit message should mention what makes this device incompatible with
> the existing device.

Thanks!

I have added this note in the commit message which will be part of a v3, 
coming after I hopefully receive a few more comments on the other parts 
of this change:

The HX83100A presents touch events on its internal bus rather than 
offering a dedicated event register like the other chips in this family do.

Felix
Conor Dooley May 12, 2024, 12:04 p.m. UTC | #2 
On Sat, May 11, 2024 at 10:10:08AM -0400, Felix Kaechele wrote:
> On 2024-05-11 08:38, Conor Dooley wrote:
> > On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
> > > Add a compatible string for the Himax HX83100A touch controller.
> > > 
> > > Signed-off-by: Felix Kaechele <felix@kaechele.ca>
> > 
> > Commit message should mention what makes this device incompatible with
> > the existing device.
> 
> Thanks!
> 
> I have added this note in the commit message which will be part of a v3,
> coming after I hopefully receive a few more comments on the other parts of
> this change:
> 
> The HX83100A presents touch events on its internal bus rather than offering
> a dedicated event register like the other chips in this family do.

Ye, that sounds good. W/ that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.