diff mbox series

configure.ac: fix sixaxis build without tools

Message ID 20240508175416.635797-1-fontaine.fabrice@gmail.com
State New
Headers show
Series configure.ac: fix sixaxis build without tools | expand

Commit Message

Fabrice Fontaine May 8, 2024, 5:54 p.m. UTC 
Fix the following build failure with --enable-sixaxis --enable-udev
--disable-tools raised since version 5.73 and
https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=9f71892b63f6b65dab874a633d88ae2dcad93a16:

/home/autobuild/autobuild/instance-2/output-1/host/lib/gcc/x86_64-buildroot-linux-musl/12.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: plugins/bluetoothd-sixaxis.o: in function `sixaxis_init':
sixaxis.c:(.text.sixaxis_init+0x23): undefined reference to `udev_new'

Fixes:
 - http://autobuild.buildroot.org/results/c337d0f473c5fbb3e6cda1317ba06f5e2b16a43e
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com May 8, 2024, 7:40 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=851667

---Test result---

Test Summary:
CheckPatch                    FAIL      0.73 seconds
GitLint                       FAIL      0.53 seconds
BuildEll                      PASS      24.68 seconds
BluezMake                     PASS      1616.78 seconds
MakeCheck                     PASS      12.92 seconds
MakeDistcheck                 PASS      181.91 seconds
CheckValgrind                 PASS      252.33 seconds
CheckSmatch                   PASS      357.71 seconds
bluezmakeextell               PASS      121.94 seconds
IncrementalBuild              PASS      1365.10 seconds
ScanBuild                     PASS      972.12 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
configure.ac: fix sixaxis build without tools
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#92: 
https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=9f71892b63f6b65dab874a633d88ae2dcad93a16:

/github/workspace/src/src/13659022.patch total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13659022.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
configure.ac: fix sixaxis build without tools

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
5: B1 Line exceeds max length (103>80): "https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=9f71892b63f6b65dab874a633d88ae2dcad93a16:"
7: B1 Line exceeds max length (199>80): "/home/autobuild/autobuild/instance-2/output-1/host/lib/gcc/x86_64-buildroot-linux-musl/12.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: plugins/bluetoothd-sixaxis.o: in function `sixaxis_init':"
10: B1 Line exceeds max length (82>80): " - http://autobuild.buildroot.org/results/c337d0f473c5fbb3e6cda1317ba06f5e2b16a43e"


---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org May 8, 2024, 9:10 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed,  8 May 2024 19:54:16 +0200 you wrote:
> Fix the following build failure with --enable-sixaxis --enable-udev
> --disable-tools raised since version 5.73 and
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=9f71892b63f6b65dab874a633d88ae2dcad93a16:
> 
> /home/autobuild/autobuild/instance-2/output-1/host/lib/gcc/x86_64-buildroot-linux-musl/12.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: plugins/bluetoothd-sixaxis.o: in function `sixaxis_init':
> sixaxis.c:(.text.sixaxis_init+0x23): undefined reference to `udev_new'
> 
> [...]

Here is the summary with links:
  - configure.ac: fix sixaxis build without tools
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f4795bf64dbf

You are awesome, thank you!
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 9dea70ddc..8b3cdb4e8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -226,7 +226,7 @@  AM_CONDITIONAL(MONITOR, test "${enable_monitor}" != "no")
 
 AC_ARG_ENABLE(udev, AS_HELP_STRING([--disable-udev],
 		[disable udev device support]), [enable_udev=${enableval}])
-if (test "${enable_tools}" != "no" && test "${enable_udev}" != "no"); then
+if (test "${enable_udev}" != "no"); then
 	PKG_CHECK_MODULES(UDEV, libudev >= 196)
 	AC_DEFINE(HAVE_UDEV, 1, [Define to 1 if udev is required])
 fi