Message ID | 20240503035105.93280-1-jhubbard@nvidia.com |
---|---|
Headers | show |
Series | selftests/cgroups: fix clang build failures, warnings | expand |
On Thu, May 02, 2024 at 08:51:02PM -0700, John Hubbard wrote: > First of all, in order to build with clang at all, one must first apply > Valentin Obst's build fix for LLVM [1]. Once that is done, then when > building with clang, via: > > make LLVM=1 -C tools/testing/selftests > > ...clang is pickier than gcc, about which version of abs(3) to call, > depending on the argument type: > > int abs(int j); > long labs(long j); > long long llabs(long long j); > > ...and this is causing both build failures and warnings, when running: > > make LLVM=1 -C tools/testing/selftests > > Fix this by calling labs() in value_close(), because the arguments are > unambiguously "long" type. > > [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ > > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev> Thanks!
On Thu, May 02, 2024 at 08:51:04PM -0700, John Hubbard wrote: > First of all, in order to build with clang at all, one must first apply > Valentin Obst's build fix for LLVM [1]. Once that is done, then when > building with clang, via: > > make LLVM=1 -C tools/testing/selftests > > ...clang generates warning here, because struct cpu_hogger has multiple > fields, and the code is initializing an array of these structs, and it > is incorrect to specify a single NULL value as the initializer. > > Fix this by initializing with {}, so that the compiler knows to use > default initializer values for all fields in each array entry. > > [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ > > Signed-off-by: John Hubbard <jhubbard@nvidia.com> Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
On Thu, May 02, 2024 at 08:51:01PM -0700, John Hubbard wrote: > Hi, > > Just a bunch of fixes as part of my work to make selftests build cleanly > with clang. > > Enjoy! > > thanks, > John Hubbard > > > John Hubbard (4): > selftests/cgroup: fix clang build failures for abs() calls > selftests/cgroup: fix clang warnings: uninitialized fd variable > selftests/cgroup: cpu_hogger init: use {} instead of {NULL} > selftests/cgroup: fix uninitialized variables in test_zswap.c Applied to cgroup/for-6.10. Thanks.