| Message ID | 20240430091144.10744-1-hyperlyzcs@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [V3,1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb | expand |
* I would usually expect a corresponding cover letter for patch series. * Would you like to add parentheses to the function name in the summary phrase? > When dma_alloc_coherent() or qla2x00_start_sp() return an error, call returned? > the callback function qla2x00_els_dcmd_sp_free in qla2x00_sp_release > will call qla2x00_free_fcport() to kfree fcport. We shouldn't call free “fcport”? > qla2x00_free_fcport() again in the error handling path. paths? > Fix this by cleaning the duplicate qla2x00_free_fcport() calls up. Would the wording “Thus delete duplicate qla2x00_free_fcport() calls.” be a bit nicer? … > --- > V2 -> V3: Improve patch summary and provide a patch serises with two separate update steps … * How do you think about to avoid the repetition of version identifiers (according to the selected enumeration style)? * You would probably like to avoid another typo here. Regards, Markus
Would you like to use the summary phrase “Use common error handling code in qla24xx_els_dcmd_iocb()”? > To avoid duplicate error handling code a bit more, use more common goto > chain in qla24xx_els_dcmd_iocb. How do you think about the following wording? Add a jump target so that a bit of exception handling can be better reused at the end of this function implementation. Can the tag “Suggested-by” be helpful for an improved change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n586 Regards, Markus
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 0b41e8a06602..faec66bd1951 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode, if (!elsio->u.els_logo.els_logo_pyld) { /* ref: INIT */ kref_put(&sp->cmd_kref, qla2x00_sp_release); - qla2x00_free_fcport(fcport); return QLA_FUNCTION_FAILED; } @@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode, if (rval != QLA_SUCCESS) { /* ref: INIT */ kref_put(&sp->cmd_kref, qla2x00_sp_release); - qla2x00_free_fcport(fcport); return QLA_FUNCTION_FAILED; }
When dma_alloc_coherent() or qla2x00_start_sp() return an error, the callback function qla2x00_els_dcmd_sp_free in qla2x00_sp_release will call qla2x00_free_fcport() to kfree fcport. We shouldn't call qla2x00_free_fcport() again in the error handling path. Fix this by cleaning the duplicate qla2x00_free_fcport() calls up. Fixes: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport") Signed-off-by: Yongzhi Liu <hyperlyzcs@gmail.com> --- V2 -> V3: Improve patch summary and provide a patch serises with two separate update steps V1 -> V2: Optimisation of exception handling drivers/scsi/qla2xxx/qla_iocb.c | 2 -- 1 file changed, 2 deletions(-)