| Message ID | 20240429-usb-link-dtsi-v1-8-87c341b55cdf@linaro.org |
|---|---|
| State | Accepted |
| Commit | d02c0027ea20f67a8dcf023786eb993abee2179e |
| Headers | show |
| Series | arm64: dts: qcom: move common USB-related properties to SoC dtsi | expand |
On 29/04/2024 14:43, Dmitry Baryshkov wrote: > The orientation-switch of the USB+DP QMP PHY is not a property of the > board, it is a design property of the QMP PHY itself. Move the property > from board DTS to SoC DTSI. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 -- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 2 -- > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 -- > arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 1 - > arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 ++ > 5 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > index f786d9114936..98934e4a81b2 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > @@ -1279,8 +1279,6 @@ &usb_dp_qmpphy { > vdda-phy-supply = <&vreg_l3e_1p2>; > vdda-pll-supply = <&vreg_l3f_0p88>; > > - orientation-switch; > - > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 56800ab903a1..d3fd00176233 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -972,8 +972,6 @@ &usb_dp_qmpphy { > vdda-phy-supply = <&vreg_l3e_1p2>; > vdda-pll-supply = <&vreg_l3f_0p91>; > > - orientation-switch; > - > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index d0b373da39d4..1d487c42a39b 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -1156,8 +1156,6 @@ &usb_dp_qmpphy { > vdda-phy-supply = <&vreg_l3e_1p2>; > vdda-pll-supply = <&vreg_l3f_0p88>; > > - orientation-switch; > - > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > index 7a8d5c34e9e6..92a88fb05609 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts > @@ -757,7 +757,6 @@ &usb_1_hsphy { > &usb_dp_qmpphy { > vdda-phy-supply = <&pm8550vs_2_l3>; > vdda-pll-supply = <&pm8550ve_l3>; > - orientation-switch; > > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 3ada5a30ecb7..9980504f66db 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -3170,6 +3170,8 @@ usb_dp_qmpphy: phy@88e8000 { > #clock-cells = <1>; > #phy-cells = <1>; > > + orientation-switch; > + > status = "disabled"; > > ports { > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 29.04.2024 2:43 PM, Dmitry Baryshkov wrote: > The orientation-switch of the USB+DP QMP PHY is not a property of the > board, it is a design property of the QMP PHY itself. Move the property > from board DTS to SoC DTSI. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts index f786d9114936..98934e4a81b2 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts @@ -1279,8 +1279,6 @@ &usb_dp_qmpphy { vdda-phy-supply = <&vreg_l3e_1p2>; vdda-pll-supply = <&vreg_l3f_0p88>; - orientation-switch; - status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts index 56800ab903a1..d3fd00176233 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts @@ -972,8 +972,6 @@ &usb_dp_qmpphy { vdda-phy-supply = <&vreg_l3e_1p2>; vdda-pll-supply = <&vreg_l3f_0p91>; - orientation-switch; - status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts index d0b373da39d4..1d487c42a39b 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts @@ -1156,8 +1156,6 @@ &usb_dp_qmpphy { vdda-phy-supply = <&vreg_l3e_1p2>; vdda-pll-supply = <&vreg_l3f_0p88>; - orientation-switch; - status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts index 7a8d5c34e9e6..92a88fb05609 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts @@ -757,7 +757,6 @@ &usb_1_hsphy { &usb_dp_qmpphy { vdda-phy-supply = <&pm8550vs_2_l3>; vdda-pll-supply = <&pm8550ve_l3>; - orientation-switch; status = "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 3ada5a30ecb7..9980504f66db 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -3170,6 +3170,8 @@ usb_dp_qmpphy: phy@88e8000 { #clock-cells = <1>; #phy-cells = <1>; + orientation-switch; + status = "disabled"; ports {
The orientation-switch of the USB+DP QMP PHY is not a property of the board, it is a design property of the QMP PHY itself. Move the property from board DTS to SoC DTSI. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 -- arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 2 -- arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 -- arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 1 - arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 ++ 5 files changed, 2 insertions(+), 7 deletions(-)