| Message ID | 20240303192040.8116-1-bergh.jonathan@gmail.com |
|---|---|
| Headers | show |
| Series | staging: media: av7110: These patches address various code style and formatting issues in the av7110 driver | expand |
Hi Jonathan, On 03/03/2024 20:20, Jonathan Bergh wrote: > The following patches fix a number of code style issues identified by > checkpatch in the av7110 driver. > > Jonathan Bergh (9): > staging: media: av7110: Fix formatting problem where trailing statements > should be on a new line > staging: media: av7110: Remove braces for single line statement blocks > staging: media: av7110: Remove spaces between function name and > opening parenthesis > staging: media: av7110: Fix formatting of pointers to meet coding > style guidelines > staging: media: av7110: Fix block comments to meet code style > guidelines > staging: media: av7110: Remove extra whitespace before opening '['s > staging: media: av7110: Remove extra whitespace before ',' > staging: media: av7110: Ensure whitespace ahead of opening brace '{' > staging: media: av7110: Ensure newline after variable declarations > > drivers/staging/media/av7110/sp8870.c | 136 +++++++++++++------------- > 1 file changed, 70 insertions(+), 66 deletions(-) > I'm sorry, but I will reject this series. This is an old driver that is not under active development. It is not worth the review effort I have to put into reviewing these cleanup patches. As the TODO file says: - Cleanup patches for the drivers here won't be accepted. I mentioned that before, so I'm not sure why you post another version of cleanup patches. Regards, Hans
The following patches fix a number of code style issues identified by checkpatch in the av7110 driver. Jonathan Bergh (9): staging: media: av7110: Fix formatting problem where trailing statements should be on a new line staging: media: av7110: Remove braces for single line statement blocks staging: media: av7110: Remove spaces between function name and opening parenthesis staging: media: av7110: Fix formatting of pointers to meet coding style guidelines staging: media: av7110: Fix block comments to meet code style guidelines staging: media: av7110: Remove extra whitespace before opening '['s staging: media: av7110: Remove extra whitespace before ',' staging: media: av7110: Ensure whitespace ahead of opening brace '{' staging: media: av7110: Ensure newline after variable declarations drivers/staging/media/av7110/sp8870.c | 136 +++++++++++++------------- 1 file changed, 70 insertions(+), 66 deletions(-)