| Message ID | 20240419211650.2657096-4-jthies@google.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: ucsi: Update UCSI alternate mode | expand |
On Fri, Apr 19, 2024 at 09:16:49PM +0000, Jameson Thies wrote: > Delay the ucsi_check_altmodes task to be inline with surrounding partner > tasks. This allows partner, cable and identity discovery to complete > before alternate mode registration. With that order, alternate mode > discovery can be used to indicate the ucsi driver has completed > discovery. > > Signed-off-by: Jameson Thies <jthies@google.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/ucsi/ucsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c > index b8d56a443531f..cd4c3b7a5d989 100644 > --- a/drivers/usb/typec/ucsi/ucsi.c > +++ b/drivers/usb/typec/ucsi/ucsi.c > @@ -963,7 +963,7 @@ static void ucsi_pwr_opmode_change(struct ucsi_connector *con) > con->rdo = con->status.request_data_obj; > typec_set_pwr_opmode(con->port, TYPEC_PWR_MODE_PD); > ucsi_partner_task(con, ucsi_get_src_pdos, 30, 0); > - ucsi_partner_task(con, ucsi_check_altmodes, 30, 0); > + ucsi_partner_task(con, ucsi_check_altmodes, 30, HZ); > ucsi_partner_task(con, ucsi_register_partner_pdos, 1, HZ); > break; > case UCSI_CONSTAT_PWR_OPMODE_TYPEC1_5: > @@ -1247,7 +1247,7 @@ static void ucsi_handle_connector_change(struct work_struct *work) > } > > if (con->status.change & UCSI_CONSTAT_CAM_CHANGE) > - ucsi_partner_task(con, ucsi_check_altmodes, 1, 0); > + ucsi_partner_task(con, ucsi_check_altmodes, 1, HZ); > > out_unlock: > mutex_unlock(&con->lock); > -- > 2.44.0.769.g3c40516874-goog
On Fri, Apr 19, 2024 at 09:16:49PM +0000, Jameson Thies wrote: > Delay the ucsi_check_altmodes task to be inline with surrounding partner > tasks. This allows partner, cable and identity discovery to complete > before alternate mode registration. With that order, alternate mode > discovery can be used to indicate the ucsi driver has completed > discovery. > > Signed-off-by: Jameson Thies <jthies@google.com> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > drivers/usb/typec/ucsi/ucsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c > index b8d56a443531f..cd4c3b7a5d989 100644 > --- a/drivers/usb/typec/ucsi/ucsi.c > +++ b/drivers/usb/typec/ucsi/ucsi.c > @@ -963,7 +963,7 @@ static void ucsi_pwr_opmode_change(struct ucsi_connector *con) > con->rdo = con->status.request_data_obj; > typec_set_pwr_opmode(con->port, TYPEC_PWR_MODE_PD); > ucsi_partner_task(con, ucsi_get_src_pdos, 30, 0); > - ucsi_partner_task(con, ucsi_check_altmodes, 30, 0); > + ucsi_partner_task(con, ucsi_check_altmodes, 30, HZ); > ucsi_partner_task(con, ucsi_register_partner_pdos, 1, HZ); > break; > case UCSI_CONSTAT_PWR_OPMODE_TYPEC1_5: > @@ -1247,7 +1247,7 @@ static void ucsi_handle_connector_change(struct work_struct *work) > } > > if (con->status.change & UCSI_CONSTAT_CAM_CHANGE) > - ucsi_partner_task(con, ucsi_check_altmodes, 1, 0); > + ucsi_partner_task(con, ucsi_check_altmodes, 1, HZ); > > out_unlock: > mutex_unlock(&con->lock); > -- > 2.44.0.769.g3c40516874-goog >
diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index b8d56a443531f..cd4c3b7a5d989 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -963,7 +963,7 @@ static void ucsi_pwr_opmode_change(struct ucsi_connector *con) con->rdo = con->status.request_data_obj; typec_set_pwr_opmode(con->port, TYPEC_PWR_MODE_PD); ucsi_partner_task(con, ucsi_get_src_pdos, 30, 0); - ucsi_partner_task(con, ucsi_check_altmodes, 30, 0); + ucsi_partner_task(con, ucsi_check_altmodes, 30, HZ); ucsi_partner_task(con, ucsi_register_partner_pdos, 1, HZ); break; case UCSI_CONSTAT_PWR_OPMODE_TYPEC1_5: @@ -1247,7 +1247,7 @@ static void ucsi_handle_connector_change(struct work_struct *work) } if (con->status.change & UCSI_CONSTAT_CAM_CHANGE) - ucsi_partner_task(con, ucsi_check_altmodes, 1, 0); + ucsi_partner_task(con, ucsi_check_altmodes, 1, HZ); out_unlock: mutex_unlock(&con->lock);
Delay the ucsi_check_altmodes task to be inline with surrounding partner tasks. This allows partner, cable and identity discovery to complete before alternate mode registration. With that order, alternate mode discovery can be used to indicate the ucsi driver has completed discovery. Signed-off-by: Jameson Thies <jthies@google.com> --- drivers/usb/typec/ucsi/ucsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)