| Message ID | 20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org |
|---|---|
| Headers | show |
| Series | backlight: Constify lcd_ops | expand |
Hi for patches 16, 17 and 18: Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Best regards Thomas Am 14.04.24 um 18:35 schrieb Krzysztof Kozlowski: > Hi, > > Dependencies > ============ > All further patches depend on the first patch. Therefore everything > could go via backlight tree (please ack) or via cross-tree pulls. Or > whatever maintainer choose, just coordinate this with backlight. > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (18): > backlight: Constify lcd_ops > backlight: ams369fg06: Constify lcd_ops > backlight: corgi_lcd: Constify lcd_ops > backlight: hx8357: Constify lcd_ops > backlight: ili922x: Constify lcd_ops > backlight: ili9320: Constify lcd_ops > backlight: jornada720_lcd: Constify lcd_ops > backlight: l4f00242t03: Constify lcd_ops > backlight: lms283gf05: Constify lcd_ops > backlight: lms501kf03: Constify lcd_ops > backlight: ltv350qv: Constify lcd_ops > backlight: otm3225a: Constify lcd_ops > backlight: platform_lcd: Constify lcd_ops > backlight: tdo24m: Constify lcd_ops > HID: picoLCD: Constify lcd_ops > fbdev: clps711x: Constify lcd_ops > fbdev: imx: Constify lcd_ops > fbdev: omap: lcd_ams_delta: Constify lcd_ops > > drivers/hid/hid-picolcd_lcd.c | 2 +- > drivers/video/backlight/ams369fg06.c | 2 +- > drivers/video/backlight/corgi_lcd.c | 2 +- > drivers/video/backlight/hx8357.c | 2 +- > drivers/video/backlight/ili922x.c | 2 +- > drivers/video/backlight/ili9320.c | 2 +- > drivers/video/backlight/jornada720_lcd.c | 2 +- > drivers/video/backlight/l4f00242t03.c | 2 +- > drivers/video/backlight/lcd.c | 4 ++-- > drivers/video/backlight/lms283gf05.c | 2 +- > drivers/video/backlight/lms501kf03.c | 2 +- > drivers/video/backlight/ltv350qv.c | 2 +- > drivers/video/backlight/otm3225a.c | 2 +- > drivers/video/backlight/platform_lcd.c | 2 +- > drivers/video/backlight/tdo24m.c | 2 +- > drivers/video/fbdev/clps711x-fb.c | 2 +- > drivers/video/fbdev/imxfb.c | 2 +- > drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- > include/linux/lcd.h | 6 +++--- > 19 files changed, 22 insertions(+), 22 deletions(-) > --- > base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39 > change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8 > > Best regards,
On 15/04/2024 08:56, Thomas Zimmermann wrote: > Hi > > for patches 16, 17 and 18: > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> This does not work like this. Toolset will apply your review tag for EVERYTHING. You must provide tag under each individual patch. Best regards, Krzysztof
On Sun, Apr 14, 2024 at 06:35:59PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' passed in lcd_device_register() is not modified by core > backlight code, so it can be made const for code safety. This allows > drivers to also define the structure as const. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Sun, Apr 14, 2024 at 06:36:01PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Sun, Apr 14, 2024 at 06:36:03PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Sun, Apr 14, 2024 at 06:36:05PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Sun, Apr 14, 2024 at 06:36:07PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Sun, Apr 14, 2024 at 06:36:09PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Sun, Apr 14, 2024 at 06:36:11PM +0200, Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Sun, Apr 14, 2024 at 06:35:58PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Dependencies > ============ > All further patches depend on the first patch. Therefore everything > could go via backlight tree (please ack) or via cross-tree pulls. Or > whatever maintainer choose, just coordinate this with backlight. Thanks for the tidy up. I've added my Reviewed-by: to all the backlight patches (for Lee) and I'm happy with the other patches too... but I didn't want my R-b on the HID and fbdev patches to be confused for an ack. Daniel. > --- > Krzysztof Kozlowski (18): > backlight: Constify lcd_ops > backlight: ams369fg06: Constify lcd_ops > backlight: corgi_lcd: Constify lcd_ops > backlight: hx8357: Constify lcd_ops > backlight: ili922x: Constify lcd_ops > backlight: ili9320: Constify lcd_ops > backlight: jornada720_lcd: Constify lcd_ops > backlight: l4f00242t03: Constify lcd_ops > backlight: lms283gf05: Constify lcd_ops > backlight: lms501kf03: Constify lcd_ops > backlight: ltv350qv: Constify lcd_ops > backlight: otm3225a: Constify lcd_ops > backlight: platform_lcd: Constify lcd_ops > backlight: tdo24m: Constify lcd_ops > HID: picoLCD: Constify lcd_ops > fbdev: clps711x: Constify lcd_ops > fbdev: imx: Constify lcd_ops > fbdev: omap: lcd_ams_delta: Constify lcd_ops > > drivers/hid/hid-picolcd_lcd.c | 2 +- > drivers/video/backlight/ams369fg06.c | 2 +- > drivers/video/backlight/corgi_lcd.c | 2 +- > drivers/video/backlight/hx8357.c | 2 +- > drivers/video/backlight/ili922x.c | 2 +- > drivers/video/backlight/ili9320.c | 2 +- > drivers/video/backlight/jornada720_lcd.c | 2 +- > drivers/video/backlight/l4f00242t03.c | 2 +- > drivers/video/backlight/lcd.c | 4 ++-- > drivers/video/backlight/lms283gf05.c | 2 +- > drivers/video/backlight/lms501kf03.c | 2 +- > drivers/video/backlight/ltv350qv.c | 2 +- > drivers/video/backlight/otm3225a.c | 2 +- > drivers/video/backlight/platform_lcd.c | 2 +- > drivers/video/backlight/tdo24m.c | 2 +- > drivers/video/fbdev/clps711x-fb.c | 2 +- > drivers/video/fbdev/imxfb.c | 2 +- > drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- > include/linux/lcd.h | 6 +++--- > 19 files changed, 22 insertions(+), 22 deletions(-) > --- > base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39 > change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8 > > Best regards, > -- > Krzysztof Kozlowski <krzk@kernel.org> >
On Sun, 14 Apr 2024 18:36:13 +0200 Krzysztof Kozlowski wrote: > 'struct lcd_ops' is not modified by core backlight code, so it can be > made const for increased code safety. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org> > --- > > Depends on the first patch in the series. > --- > drivers/hid/hid-picolcd_lcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c > index 0c4b76de8ae5..061a33ba7b1d 100644 > --- a/drivers/hid/hid-picolcd_lcd.c > +++ b/drivers/hid/hid-picolcd_lcd.c > @@ -46,7 +46,7 @@ static int picolcd_check_lcd_fb(struct lcd_device *ldev, struct fb_info *fb) > return fb && fb == picolcd_fbinfo((struct picolcd_data *)lcd_get_data(ldev)); > } > > -static struct lcd_ops picolcd_lcdops = { > +static const struct lcd_ops picolcd_lcdops = { > .get_contrast = picolcd_get_contrast, > .set_contrast = picolcd_set_contrast, > .check_fb = picolcd_check_lcd_fb, >
On Mon, 15 Apr 2024, Krzysztof Kozlowski wrote: > On 15/04/2024 08:56, Thomas Zimmermann wrote: > > Hi > > > > for patches 16, 17 and 18: > > > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > > This does not work like this. Toolset will apply your review tag for > EVERYTHING. You must provide tag under each individual patch. And for that to not happen now, you have to resubmit the set. :)
Hi, Dependencies ============ All further patches depend on the first patch. Therefore everything could go via backlight tree (please ack) or via cross-tree pulls. Or whatever maintainer choose, just coordinate this with backlight. Best regards, Krzysztof --- Krzysztof Kozlowski (18): backlight: Constify lcd_ops backlight: ams369fg06: Constify lcd_ops backlight: corgi_lcd: Constify lcd_ops backlight: hx8357: Constify lcd_ops backlight: ili922x: Constify lcd_ops backlight: ili9320: Constify lcd_ops backlight: jornada720_lcd: Constify lcd_ops backlight: l4f00242t03: Constify lcd_ops backlight: lms283gf05: Constify lcd_ops backlight: lms501kf03: Constify lcd_ops backlight: ltv350qv: Constify lcd_ops backlight: otm3225a: Constify lcd_ops backlight: platform_lcd: Constify lcd_ops backlight: tdo24m: Constify lcd_ops HID: picoLCD: Constify lcd_ops fbdev: clps711x: Constify lcd_ops fbdev: imx: Constify lcd_ops fbdev: omap: lcd_ams_delta: Constify lcd_ops drivers/hid/hid-picolcd_lcd.c | 2 +- drivers/video/backlight/ams369fg06.c | 2 +- drivers/video/backlight/corgi_lcd.c | 2 +- drivers/video/backlight/hx8357.c | 2 +- drivers/video/backlight/ili922x.c | 2 +- drivers/video/backlight/ili9320.c | 2 +- drivers/video/backlight/jornada720_lcd.c | 2 +- drivers/video/backlight/l4f00242t03.c | 2 +- drivers/video/backlight/lcd.c | 4 ++-- drivers/video/backlight/lms283gf05.c | 2 +- drivers/video/backlight/lms501kf03.c | 2 +- drivers/video/backlight/ltv350qv.c | 2 +- drivers/video/backlight/otm3225a.c | 2 +- drivers/video/backlight/platform_lcd.c | 2 +- drivers/video/backlight/tdo24m.c | 2 +- drivers/video/fbdev/clps711x-fb.c | 2 +- drivers/video/fbdev/imxfb.c | 2 +- drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- include/linux/lcd.h | 6 +++--- 19 files changed, 22 insertions(+), 22 deletions(-) --- base-commit: 9ed46da14b9b9b2ad4edb3b0c545b6dbe5c00d39 change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8 Best regards,