| Message ID | 20240408-qcom-pmic-gpio-hog-v1-0-f61fc5323110@z3ntu.xyz |
|---|---|
| Headers | show |
| Series | Allow gpio-hog nodes in qcom,pmic-gpio bindings (& dt fixup) | expand |
On 4/8/24 18:39, Luca Weiss wrote: > Allow specifying a GPIO hog, as already used on > qcom-msm8974-lge-nexus5-hammerhead.dts. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > index a786357ed1af..510a05369dbb 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > @@ -424,6 +424,10 @@ patternProperties: > $ref: "#/$defs/qcom-pmic-gpio-state" > additionalProperties: false > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": I see a couple bindings do this, but I'm not sure if we want two allow two styles for no reason.. Rob? Konrad
On Montag, 8. April 2024 19:26:49 CEST Konrad Dybcio wrote: > > On 4/8/24 18:39, Luca Weiss wrote: > > Allow specifying a GPIO hog, as already used on > > qcom-msm8974-lge-nexus5-hammerhead.dts. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > > index a786357ed1af..510a05369dbb 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > > @@ -424,6 +424,10 @@ patternProperties: > > $ref: "#/$defs/qcom-pmic-gpio-state" > > additionalProperties: false > > > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > I see a couple bindings do this, but I'm not sure if we want two > allow two styles for no reason.. Rob? This regex is actually from the gpio-hog.yaml base https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/gpio/gpio-hog.yaml#L23 Why it's made this way I cannot tell you, but I didn't want to 'artifically' restrict the pattern for qcom,pmic-gpio. > > Konrad >
On 08/04/2024 20:36, Luca Weiss wrote: > On Montag, 8. April 2024 19:26:49 CEST Konrad Dybcio wrote: >> >> On 4/8/24 18:39, Luca Weiss wrote: >>> Allow specifying a GPIO hog, as already used on >>> qcom-msm8974-lge-nexus5-hammerhead.dts. >>> >>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >>> --- >>> .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> index a786357ed1af..510a05369dbb 100644 >>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >>> @@ -424,6 +424,10 @@ patternProperties: >>> $ref: "#/$defs/qcom-pmic-gpio-state" >>> additionalProperties: false >>> >>> + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": >> >> I see a couple bindings do this, but I'm not sure if we want two >> allow two styles for no reason.. Rob? > > This regex is actually from the gpio-hog.yaml base > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/gpio/gpio-hog.yaml#L23 > > Why it's made this way I cannot tell you, but I didn't want to 'artifically' > restrict the pattern for qcom,pmic-gpio. Use the same as in tlmm: https://lore.kernel.org/linux-devicetree/20221121081221.30745-1-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof
Resolve the dt validation failure on Nexus 5. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Luca Weiss (2): dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes ARM: dts: qcom: msm8974-hammerhead: Update gpio hog node name .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 12 ++++++++++++ .../arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) --- base-commit: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc change-id: 20240408-qcom-pmic-gpio-hog-2b4c5f103126 Best regards,