| Message ID | 20240401082746.7654-1-jtornosm@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,v3] net: usb: ax88179_178a: non necessary second random mac address | expand |
On Mon, 1 Apr 2024 10:27:25 +0200 Jose Ignacio Tornos Martinez wrote: > If the mac address can not be read from the device registers or the > devicetree, a random address is generated, but this was already done from > usbnet_probe, so it is not necessary to call eth_hw_addr_random from here > again to generate another random address. > > Indeed, when reset was also executed from bind, generate another random mac > address invalidated the check from usbnet_probe to configure if the assigned > mac address for the interface was random or not, because it is comparing > with the initial generated random address. Now, with only a reset from open > operation, it is just a harmless simplification. You need to wait for the other patch to get merged, then on Thursday after that the trees will get merged together, and then you can post this :( Otherwise we'll have a conflict.
Understood, I will repost when the other one is merged and with the new context diff. Thanks Best regards José Ignacio
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 8ca8ace93d9c..08c9b2ab9711 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1276,7 +1276,6 @@ static void ax88179_get_mac_addr(struct usbnet *dev) dev->net->addr_assign_type = NET_ADDR_PERM; } else { netdev_info(dev->net, "invalid MAC address, using random\n"); - eth_hw_addr_random(dev->net); } ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
If the mac address can not be read from the device registers or the devicetree, a random address is generated, but this was already done from usbnet_probe, so it is not necessary to call eth_hw_addr_random from here again to generate another random address. Indeed, when reset was also executed from bind, generate another random mac address invalidated the check from usbnet_probe to configure if the assigned mac address for the interface was random or not, because it is comparing with the initial generated random address. Now, with only a reset from open operation, it is just a harmless simplification. Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> --- v3: - Send the patch separately to net-next and remove fixes and stable tags. v2: - Split the fix and the improvement in two patches and keep curly-brackets as Simon Horman suggests. v1: https://lore.kernel.org/netdev/20240325173155.671807-1-jtornosm@redhat.com/ drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1 deletion(-)