| Message ID | 20240331-typec-fix-example-v2-1-f56fffe4f37c@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: usb: qcom,pmic-typec: update example to follow connector schema | expand |
On Sun, Mar 31, 2024 at 12:21:15AM +0200, Dmitry Baryshkov wrote: > Update Qualcomm PMIC Type-C examples to follow the USB-C connector > schema. The USB-C connector should have three ports (USB HS @0, > SSTX/RX @1 and SBU @2 lanes). Reorder ports accordingly and add SBU port > connected to the SBU mux (e.g. FSA4480). > > Fixes: 00bb478b829e ("dt-bindings: usb: Add Qualcomm PMIC Type-C") > Reported-by: Luca Weiss <luca.weiss@fairphone.com> > Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Update examples to follow usb-c-connector schema wrt. ports definitions. > --- Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Sun, Mar 31, 2024 at 09:17:20AM +0200, Greg Kroah-Hartman wrote: > On Sun, Mar 31, 2024 at 12:21:15AM +0200, Dmitry Baryshkov wrote: > > Update Qualcomm PMIC Type-C examples to follow the USB-C connector > > schema. The USB-C connector should have three ports (USB HS @0, > > SSTX/RX @1 and SBU @2 lanes). Reorder ports accordingly and add SBU port > > connected to the SBU mux (e.g. FSA4480). > > > > Fixes: 00bb478b829e ("dt-bindings: usb: Add Qualcomm PMIC Type-C") > > Reported-by: Luca Weiss <luca.weiss@fairphone.com> > > Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > Update examples to follow usb-c-connector schema wrt. ports definitions. > > --- > > Hi, > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > a patch that has triggered this response. He used to manually respond > to these common problems, but in order to save his sanity (he kept > writing the same thing over and over, yet to different people), I was > created. Hopefully you will not take offence and will fix the problem > in your patch and resubmit it so that it can be accepted into the Linux > kernel tree. > > You are receiving this message because of the following common error(s) > as indicated below: > > - You have marked a patch with a "Fixes:" tag for a commit that is in an > older released kernel, yet you do not have a cc: stable line in the > signed-off-by area at all, which means that the patch will not be > applied to any older kernel releases. To properly fix this, please > follow the documented rules in the > Documentation/process/stable-kernel-rules.rst file for how to resolve > this. > > If you wish to discuss this problem further, or you have questions about > how to resolve this issue, please feel free to respond to this email and > Greg will reply once he has dug out from the pending patches received > from other developers. I'm not sure that something updating the example like this needs to go to stable in the first place.
diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml index d9694570c419..fe757619e535 100644 --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml @@ -192,15 +192,22 @@ examples: port@0 { reg = <0>; - pmic_typec_mux_out: endpoint { - remote-endpoint = <&usb_phy_typec_mux_in>; + pmic_typec_hs_in: endpoint { + remote-endpoint = <&usb_hs_out>; }; }; port@1 { reg = <1>; - pmic_typec_role_switch_out: endpoint { - remote-endpoint = <&usb_role_switch_in>; + pmic_typec_ss_in: endpoint { + remote-endpoint = <&usb_phy_typec_ss_out>; + }; + }; + + port@2 { + reg = <2>; + pmic_typec_sbu: endpoint { + remote-endpoint = <&usb_mux_sbu>; }; }; }; @@ -212,8 +219,8 @@ examples: dr_mode = "otg"; usb-role-switch; port { - usb_role_switch_in: endpoint { - remote-endpoint = <&pmic_typec_role_switch_out>; + usb_hs_out: endpoint { + remote-endpoint = <&pmic_typec_hs_in>; }; }; }; @@ -221,8 +228,19 @@ examples: usb-phy { orientation-switch; port { - usb_phy_typec_mux_in: endpoint { - remote-endpoint = <&pmic_typec_mux_out>; + usb_phy_typec_ss_out: endpoint { + remote-endpoint = <&pmic_typec_ss_in>; + }; + }; + }; + + usb-mux { + orientation-switch; + mode-switch; + + port { + usb_mux_sbu: endpoint { + remote-endpoint = <&pmic_typec_sbu>; }; }; };
Update Qualcomm PMIC Type-C examples to follow the USB-C connector schema. The USB-C connector should have three ports (USB HS @0, SSTX/RX @1 and SBU @2 lanes). Reorder ports accordingly and add SBU port connected to the SBU mux (e.g. FSA4480). Fixes: 00bb478b829e ("dt-bindings: usb: Add Qualcomm PMIC Type-C") Reported-by: Luca Weiss <luca.weiss@fairphone.com> Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Update examples to follow usb-c-connector schema wrt. ports definitions. --- Changes in v2: - Dropped patch removing the role-switching port. We do not use it, but it can become useful by other designs. - Link to v1: https://lore.kernel.org/r/20240322-typec-fix-example-v1-0-6b01c347419e@linaro.org --- .../devicetree/bindings/usb/qcom,pmic-typec.yaml | 34 +++++++++++++++++----- 1 file changed, 26 insertions(+), 8 deletions(-) --- base-commit: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 change-id: 20240322-typec-fix-example-3d9b1eca853d Best regards,