mbox series

[0/3] usb: typec: ucsi: Ack connector change early

Message ID 20240327224554.1772525-1-lk@c--e.de
Headers show
Series usb: typec: ucsi: Ack connector change early | expand

Message

Christian A. Ehrhardt March 27, 2024, 10:45 p.m. UTC 
As briefly discussed here
  https://lore.kernel.org/lkml/Zf1XUrG1UbVJWzoz@kuha.fi.intel.com/
acknowledge connector change events along with the first command
in ucsi_handle_connector_change(). The connector lock should be
sufficient to protect the rest of the function and the partner
tasks.

This allows us to remove the Dell quirk in ucsi_acpi.c.
Additionally, this reduces the number of commands that are sent
with an un-acknowleged connector change event.

Christian A. Ehrhardt (3):
  usb: typec: ucsi: Stop abuse of bit definitions from ucsi.h
  usb: typec: ucsi: Never send a lone connector change ack
  usb: typec: ucsi_acpi: Remove Dell quirk

 drivers/usb/typec/ucsi/ucsi.c         | 48 ++++++++++-------------
 drivers/usb/typec/ucsi/ucsi.h         |  2 -
 drivers/usb/typec/ucsi/ucsi_acpi.c    | 56 ++-------------------------
 drivers/usb/typec/ucsi/ucsi_stm32g0.c |  1 +
 4 files changed, 25 insertions(+), 82 deletions(-)

Comments

Dmitry Baryshkov March 29, 2024, 5:56 a.m. UTC | #1 
On Thu, 28 Mar 2024 at 00:46, Christian A. Ehrhardt <lk@c--e.de> wrote:
>
> As briefly discussed here
>   https://lore.kernel.org/lkml/Zf1XUrG1UbVJWzoz@kuha.fi.intel.com/
> acknowledge connector change events along with the first command
> in ucsi_handle_connector_change(). The connector lock should be
> sufficient to protect the rest of the function and the partner
> tasks.
>
> This allows us to remove the Dell quirk in ucsi_acpi.c.
> Additionally, this reduces the number of commands that are sent
> with an un-acknowleged connector change event.
>
> Christian A. Ehrhardt (3):
>   usb: typec: ucsi: Stop abuse of bit definitions from ucsi.h
>   usb: typec: ucsi: Never send a lone connector change ack
>   usb: typec: ucsi_acpi: Remove Dell quirk
>
>  drivers/usb/typec/ucsi/ucsi.c         | 48 ++++++++++-------------
>  drivers/usb/typec/ucsi/ucsi.h         |  2 -
>  drivers/usb/typec/ucsi/ucsi_acpi.c    | 56 ++-------------------------
>  drivers/usb/typec/ucsi/ucsi_stm32g0.c |  1 +
>  4 files changed, 25 insertions(+), 82 deletions(-)

Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #
SM8450-HDK, sc8180x-primus