mbox series

[BlueZ,0/2] Allow endpoint config without local endpoint argument

Message ID 20240320144153.46408-1-silviu.barbulescu@nxp.com
Headers show
Series Allow endpoint config without local endpoint argument | expand

Message

Silviu Florian Barbulescu March 20, 2024, 2:41 p.m. UTC
Update endpoint config command to create a local endpoint for broadcast
endpoint.
This will be used to configure a broadcast source/sink if
register endpoint is done from another application like PipeWire

Sample output from using the endpoint.config with endpoint and preset
to configure a broadcast sink to connect to a BIS.
The register endpoint for the broadcast sink has been done with PipeWire.
[Waiting to connect to bluetoothd...
[bluetooth]Agent registered
[bluetooth]hci0 new_settings: powered bondable le secure-conn
cis-central cis-peripheral iso-broadcaster sync-receiver
[bluetooth][CHG[0m] Controller C0:07:E8:CE:94:CD Pairable: yes
[bluetooth]AdvertisementMonitor path registered
[bluetooth]scan on
[?2004h[bluetooth]SetDiscoveryFilter success
[bluetooth]Discovery started
[bluetooth][CHG Controller C0:07:E8:CE:94:CD Discovering: yes
[bluetooth][NEW [Device 18:41:1D:57:63:C6 18-41-1D-57-63-C6
[bluetooth][NEW Endpoint /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0
mendpoint.config /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0 48_4_1
endpoint.config /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0 48_4_1
Configuration.#0: len 0x02 type 0x01
Configuration.Sampling Frequency: 48 Khz (0x08)
Configuration.#1: len 0x02 type 0x02
Configuration.Frame Duration: 10 ms (0x01)
Configuration.#2: len 0x03 type 0x04
Configuration.Frame Length: 120 (0x0078)
BCode:
01 02 68 05 53 f1 41 5a a2 65 bb af c6 ea 03 b8 ..h.S.AZ.e......
Framing 0x00
PresentationDelay 40000
Interval 10000
PHY 0x02
SDU 120
Retransmissions 4
Latency 20
[NEW Transport /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0/fd0
[bluetooth]Endpoint /local/endpoint/baa/lc3 configured
Sample output from using the endpoint.config with endpoint and preset
to configure a broadcast source BIS.
The register endpoint has been done with PipeWire.
[Waiting to connect to bluetoothd...
[[bluetooth][0m# Agent registered
[[bluetooth][0m# hci0 new_settings: powered bondable le secure-conn
cis-central cis-peripheral iso-broadcaster sync-receiver
[[bluetooth][0m# [[CHG[0m] Controller C0:07:E8:CE:94:CD Pairable: yes
[[bluetooth][0m# AdvertisementMonitor path registered
[[bluetooth][0m# [[NEW[0m] Endpoint /org/bluez/hci0/pac_bcast0
[[bluetooth][0m# [7mendpoint.config /org/bluez/hci0/pac_bcast0 48_4_1
endpoint.config /org/bluez/hci0/pac_bcast0 48_4_1
[[1;39m[/local/endpoint/bcaa/lc3] BIG (auto/value): [0m0
[[1;39m[/local/endpoint/bcaa/lc3] Enter channel location (value/no): [0m1
[[1;39m[/local/endpoint/bcaa/lc3] Enter Metadata (value/no): [0mn
Configuration.#0: len 0x02 type 0x01
Configuration.Sampling Frequency: 48 Khz (0x08)
Configuration.#1: len 0x02 type 0x02
Configuration.Frame Duration: 10 ms (0x01)
Configuration.#2: len 0x03 type 0x04
Configuration.Frame Length: 120 (0x0078)
Configuration.#3: len 0x05 type 0x03
Configuration.Location: 0x00000001
Configuration.Location: Front Left (0x00000001)
BIG 0x00
BCode:
01 02 68 05 53 f1 41 5a a2 65 bb af c6 ea 03 b8 ..h.S.AZ.e......
Framing 0x00
PresentationDelay 40000
Interval 10000
PHY 0x02
SDU 120
Retransmissions 4
Latency 20
[[[bluetooth][0m# [[NEW[0m] Transport /org/bluez/hci0/pac_bcast0/fd0
[[bluetooth][0m# Endpoint /local/endpoint/bcaa/lc3 configured

Silviu Florian Barbulescu (2):
  bap: Fix MediaEndpoint prop codec returns 0 for bcast src endpoint
  player: Update endpoint config command to create local endpoint

 client/player.c      | 80 ++++++++++++++++++++++++++++++++++++++++++--
 profiles/audio/bap.c |  8 ++++-
 2 files changed, 84 insertions(+), 4 deletions(-)


base-commit: b8ad3490a3507476844d6c6a87b2cb336f7d4eb9

Comments

patchwork-bot+bluetooth@kernel.org March 28, 2024, 2:40 p.m. UTC | #1
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 20 Mar 2024 16:41:51 +0200 you wrote:
> Update endpoint config command to create a local endpoint for broadcast
> endpoint.
> This will be used to configure a broadcast source/sink if
> register endpoint is done from another application like PipeWire
> 
> Sample output from using the endpoint.config with endpoint and preset
> to configure a broadcast sink to connect to a BIS.
> The register endpoint for the broadcast sink has been done with PipeWire.
> [Waiting to connect to bluetoothd...
> [bluetooth]Agent registered
> [bluetooth]hci0 new_settings: powered bondable le secure-conn
> cis-central cis-peripheral iso-broadcaster sync-receiver
> [bluetooth][CHG[0m] Controller C0:07:E8:CE:94:CD Pairable: yes
> [bluetooth]AdvertisementMonitor path registered
> [bluetooth]scan on
> [?2004h[bluetooth]SetDiscoveryFilter success
> [bluetooth]Discovery started
> [bluetooth][CHG Controller C0:07:E8:CE:94:CD Discovering: yes
> [bluetooth][NEW [Device 18:41:1D:57:63:C6 18-41-1D-57-63-C6
> [bluetooth][NEW Endpoint /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0
> mendpoint.config /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0 48_4_1
> endpoint.config /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0 48_4_1
> Configuration.#0: len 0x02 type 0x01
> Configuration.Sampling Frequency: 48 Khz (0x08)
> Configuration.#1: len 0x02 type 0x02
> Configuration.Frame Duration: 10 ms (0x01)
> Configuration.#2: len 0x03 type 0x04
> Configuration.Frame Length: 120 (0x0078)
> BCode:
> 01 02 68 05 53 f1 41 5a a2 65 bb af c6 ea 03 b8 ..h.S.AZ.e......
> Framing 0x00
> PresentationDelay 40000
> Interval 10000
> PHY 0x02
> SDU 120
> Retransmissions 4
> Latency 20
> [NEW Transport /org/bluez/hci0/dev_18_41_1D_57_63_C6/pac_bcast0/fd0
> [bluetooth]Endpoint /local/endpoint/baa/lc3 configured
> Sample output from using the endpoint.config with endpoint and preset
> to configure a broadcast source BIS.
> The register endpoint has been done with PipeWire.
> [Waiting to connect to bluetoothd...
> [[bluetooth][0m# Agent registered
> [[bluetooth][0m# hci0 new_settings: powered bondable le secure-conn
> cis-central cis-peripheral iso-broadcaster sync-receiver
> [[bluetooth][0m# [[CHG[0m] Controller C0:07:E8:CE:94:CD Pairable: yes
> [[bluetooth][0m# AdvertisementMonitor path registered
> [[bluetooth][0m# [[NEW[0m] Endpoint /org/bluez/hci0/pac_bcast0
> [[bluetooth][0m# [7mendpoint.config /org/bluez/hci0/pac_bcast0 48_4_1
> endpoint.config /org/bluez/hci0/pac_bcast0 48_4_1
> [[1;39m[/local/endpoint/bcaa/lc3] BIG (auto/value): [0m0
> [[1;39m[/local/endpoint/bcaa/lc3] Enter channel location (value/no): [0m1
> [[1;39m[/local/endpoint/bcaa/lc3] Enter Metadata (value/no): [0mn
> Configuration.#0: len 0x02 type 0x01
> Configuration.Sampling Frequency: 48 Khz (0x08)
> Configuration.#1: len 0x02 type 0x02
> Configuration.Frame Duration: 10 ms (0x01)
> Configuration.#2: len 0x03 type 0x04
> Configuration.Frame Length: 120 (0x0078)
> Configuration.#3: len 0x05 type 0x03
> Configuration.Location: 0x00000001
> Configuration.Location: Front Left (0x00000001)
> BIG 0x00
> BCode:
> 01 02 68 05 53 f1 41 5a a2 65 bb af c6 ea 03 b8 ..h.S.AZ.e......
> Framing 0x00
> PresentationDelay 40000
> Interval 10000
> PHY 0x02
> SDU 120
> Retransmissions 4
> Latency 20
> [[[bluetooth][0m# [[NEW[0m] Transport /org/bluez/hci0/pac_bcast0/fd0
> [[bluetooth][0m# Endpoint /local/endpoint/bcaa/lc3 configured
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/2] bap: Add bcast source support for MediaEndpoint Codec
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0ff7392af164
  - [BlueZ,2/2] player: Allow endpoint config without local endpoint argument
    (no matching commit)

You are awesome, thank you!