diff mbox series

[4/7] usb: misc: uss720: point pp->dev to usbdev->dev

Message ID 20240312055350.205878-4-alexhenrie24@gmail.com
State New
Headers show
Series [1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP | expand

Commit Message

Alex Henrie March 12, 2024, 5:50 a.m. UTC 
This avoids a "fix this legacy no-device port driver" warning.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 drivers/usb/misc/uss720.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sudip Mukherjee March 26, 2024, 8:14 p.m. UTC | #1 
On Tue, 26 Mar 2024 at 15:16, Alex Henrie <alexhenrie24@gmail.com> wrote:
>
> This avoids a "fix this legacy no-device port driver" warning from
> parport_announce_port in drivers/parport/share.c. The parport driver now
> requires a pointer to the device struct.
>
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
diff mbox series

Patch

diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index fadceb7ab34d..be7d3fa4c150 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -720,6 +720,7 @@  static int uss720_probe(struct usb_interface *intf,
 	priv->pp = pp;
 	pp->private_data = priv;
 	pp->modes = PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_ECP | PARPORT_MODE_COMPAT;
+	pp->dev = &usbdev->dev;
 
 	/* set the USS720 control register to manual mode, no ECP compression, enable all ints */
 	set_1284_register(pp, 7, 0x00, GFP_KERNEL);