mbox series

[v3,0/3] x86: Improve ERMS usage on Zen3+

Message ID 20240208130840.533348-1-adhemerval.zanella@linaro.org
Headers show
Series x86: Improve ERMS usage on Zen3+ | expand

Message

Adhemerval Zanella Netto Feb. 8, 2024, 1:08 p.m. UTC 
For the sizes where REP MOVSB and REP STOSB are used on Zen3+ cores, the
result performance is lower than vectorized instructions (with some
input alignment showing a very large performance gap as indicated by
BZ#30995). 

The glibc enables ERMS on AMD code for sizes between 2113
(rep_movsb_threshold) and L2 cache size rep_movsb_stop_threshold or
524288 on a Zen3 core). Using the provided benchmarks from BZ#30995, the
memcpy on Ryzen 9 5900X shows:

  Size (bytes)   Destination Alignment      Throughput (GB/s)
  2113                               0                84.2448              
  2113                              15                 4.4310
  524287                             0                57.1122 
  524287                            15                4.34671

While by using vectorized instructions with the tunable
GLIBC_TUNABLES=glibc.cpu.x86_rep_movsb_threshold=1000000 it shows:

  Size (bytes)   Destination Alignment      Throughput (GB/s)
  2113                               0               124.1830             
  2113                              15               121.8720
  524287                             0                58.3212 
  524287                            15                58.5352 

Increasing the number of concurrent jobs does show improvements in ERMS
over vectorized instructions as well. The performance difference with
ERMS improves if input alignments are equal, although it does not reach
parity with the vectorized path.

The memset also shows similar performance improvement with vectorized
instructions instead of REP STOSB. On the same machine, the default
strategy shows:

  Size (bytes)   Destination Alignment      Throughput (GB/s)
  2113                               0                68.0113            
  2113                              15                56.1880
  524287                             0               119.3670
  524287                            15               116.2590

While with GLIBC_TUNABLES=glibc.cpu.x86_rep_stosb_threshold=1000000: 

  Size (bytes)   Destination Alignment      Throughput (GB/s)
  2113                               0               133.2310
  2113                              15               132.5800
  524287                             0               112.0650
  524287                            15               118.0960

I also saw a slight performance increase on 502.gcc_r (1 copy), where
where result went from 9.82 to 9.85. The benchmarks hit hard both memcpy
and memset.

Changes from v2:
- Removed rep_movsb_stop_threshold tunable.
- Simplify the memset change.

Changes from v1:
- Reword comment and commit message.

Adhemerval Zanella (3):
  x86: Fix Zen3/Zen4 ERMS selection (BZ 30994)
  x86: Do not prefer ERMS for memset on Zen3+
  x86: Expand the comment on when REP STOSB is used on memset

 sysdeps/x86/dl-cacheinfo.h                    | 43 ++++++++++---------
 .../multiarch/memset-vec-unaligned-erms.S     |  4 +-
 2 files changed, 26 insertions(+), 21 deletions(-)

Comments

Florian Weimer March 25, 2024, 3:15 p.m. UTC | #1 
* Adhemerval Zanella:

> Adhemerval Zanella (3):
>   x86: Fix Zen3/Zen4 ERMS selection (BZ 30994)
>   x86: Do not prefer ERMS for memset on Zen3+
>   x86: Expand the comment on when REP STOSB is used on memset
>
>  sysdeps/x86/dl-cacheinfo.h                    | 43 ++++++++++---------
>  .../multiarch/memset-vec-unaligned-erms.S     |  4 +-
>  2 files changed, 26 insertions(+), 21 deletions(-)

Should we backport this into release branches?

This issue was first raised as an Ubuntu downstream bug, so maybe they'd
appreciate a backport for this?  We want this backport in Fedora, so it
would help us, too.

Thanks,
Florian
H.J. Lu March 25, 2024, 3:19 p.m. UTC | #2 
On Mon, Mar 25, 2024 at 8:15 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Adhemerval Zanella:
>
> > Adhemerval Zanella (3):
> >   x86: Fix Zen3/Zen4 ERMS selection (BZ 30994)
> >   x86: Do not prefer ERMS for memset on Zen3+
> >   x86: Expand the comment on when REP STOSB is used on memset
> >
> >  sysdeps/x86/dl-cacheinfo.h                    | 43 ++++++++++---------
> >  .../multiarch/memset-vec-unaligned-erms.S     |  4 +-
> >  2 files changed, 26 insertions(+), 21 deletions(-)
>
> Should we backport this into release branches?

Yes.

> This issue was first raised as an Ubuntu downstream bug, so maybe they'd
> appreciate a backport for this?  We want this backport in Fedora, so it
> would help us, too.
>
> Thanks,
> Florian
>