diff mbox series

[2/3] arm64: dts: exynos: gs101: add poweroff node

Message ID 20240320020549.71810-2-alexey.klimov@linaro.org
State New
Headers show
Series [1/3] dt-bindings: power: reset: add gs101 poweroff bindings | expand

Commit Message

Alexey Klimov March 20, 2024, 2:05 a.m. UTC
Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
---
 arch/arm64/boot/dts/exynos/google/gs101.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski March 20, 2024, 7:15 a.m. UTC | #1
On 20/03/2024 03:05, Alexey Klimov wrote:
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---
>  arch/arm64/boot/dts/exynos/google/gs101.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 55e6bcb3689e..9def28393274 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -509,6 +509,13 @@ sysreg_apm: syscon@174204e0 {
>  		pmu_system_controller: system-controller@17460000 {
>  			compatible = "google,gs101-pmu", "syscon";
>  			reg = <0x17460000 0x10000>;
> +
> +			poweroff {
> +				compatible = "google,gs101-poweroff";
> +				samsung,syscon-phandle = <&pmu_system_controller>;

This is just senseless... you are the child of pmu, as seen in this DTS.
You do not need to reference yourself (so the PMU)!



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index 55e6bcb3689e..9def28393274 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -509,6 +509,13 @@  sysreg_apm: syscon@174204e0 {
 		pmu_system_controller: system-controller@17460000 {
 			compatible = "google,gs101-pmu", "syscon";
 			reg = <0x17460000 0x10000>;
+
+			poweroff {
+				compatible = "google,gs101-poweroff";
+				samsung,syscon-phandle = <&pmu_system_controller>;
+				offset = <0x3e9c>;
+				mask = <0x100>;
+			};
 		};
 
 		pinctrl_gpio_alive: pinctrl@174d0000 {