mbox

[PULL,0/9] target/hppa fixes for 9.0

Message ID 20240320003223.554145-1-richard.henderson@linaro.org
State New
Headers show

Pull-request

https://gitlab.com/rth7680/qemu.git tags/pull-pa-20240319

Message

Richard Henderson March 20, 2024, 12:32 a.m. UTC
The following changes since commit c62d54d0a8067ffb3d5b909276f7296d7df33fa7:

  Update version for v9.0.0-rc0 release (2024-03-19 19:13:52 +0000)

are available in the Git repository at:

  https://gitlab.com/rth7680/qemu.git tags/pull-pa-20240319

for you to fetch changes up to 518d2f4300e5c50a3e6416fd46e58373781a5267:

  target/hppa: fix do_stdby_e() (2024-03-19 14:08:02 -1000)

----------------------------------------------------------------
target/hppa: Fix load/store offset assembly for wide mode
target/hppa: Fix LDCW,S shift
target/hppa: Fix SHRPD conditions
target/hppa: Fix access_id checks
target/hppa: Exit TB after Flush Instruction Cache
target/hppa: Fix MFIA result
target hppa: Fix STDBY,E

----------------------------------------------------------------
Richard Henderson (3):
      target/hppa: Fix assemble_16 insns for wide mode
      target/hppa: Fix assemble_11a insns for wide mode
      target/hppa: Fix assemble_12a insns for wide mode

Sven Schnelle (6):
      target/hppa: ldcw,s uses static shift of 3
      target/hppa: fix shrp for wide mode
      target/hppa: fix access_id check
      target/hppa: exit tb on flush cache instructions
      target/hppa: mask privilege bits in mfia
      target/hppa: fix do_stdby_e()

 target/hppa/insns.decode | 55 +++++++++++++++++++--------------
 target/hppa/mem_helper.c | 80 +++++++++++++++++++++++++++++++++++++-----------
 target/hppa/op_helper.c  | 10 +++---
 target/hppa/translate.c  | 77 ++++++++++++++++++++++++++++++++++++++++------
 4 files changed, 166 insertions(+), 56 deletions(-)

Comments

Peter Maydell March 20, 2024, 3:05 p.m. UTC | #1
On Wed, 20 Mar 2024 at 00:33, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The following changes since commit c62d54d0a8067ffb3d5b909276f7296d7df33fa7:
>
>   Update version for v9.0.0-rc0 release (2024-03-19 19:13:52 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/rth7680/qemu.git tags/pull-pa-20240319
>
> for you to fetch changes up to 518d2f4300e5c50a3e6416fd46e58373781a5267:
>
>   target/hppa: fix do_stdby_e() (2024-03-19 14:08:02 -1000)
>
> ----------------------------------------------------------------
> target/hppa: Fix load/store offset assembly for wide mode
> target/hppa: Fix LDCW,S shift
> target/hppa: Fix SHRPD conditions
> target/hppa: Fix access_id checks
> target/hppa: Exit TB after Flush Instruction Cache
> target/hppa: Fix MFIA result
> target hppa: Fix STDBY,E
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.

-- PMM
Michael Tokarev March 21, 2024, 5:06 p.m. UTC | #2
20.03.2024 03:32, Richard Henderson :

> Richard Henderson (3):
>        target/hppa: Fix assemble_16 insns for wide mode
>        target/hppa: Fix assemble_11a insns for wide mode
>        target/hppa: Fix assemble_12a insns for wide mode
> 
> Sven Schnelle (6):
>        target/hppa: ldcw,s uses static shift of 3
>        target/hppa: fix shrp for wide mode
>        target/hppa: fix access_id check
>        target/hppa: exit tb on flush cache instructions
>        target/hppa: mask privilege bits in mfia
>        target/hppa: fix do_stdby_e()

Is it all -stable material (when appropriate)?

/mjt
Sven Schnelle March 21, 2024, 6:25 p.m. UTC | #3
Michael Tokarev <mjt@tls.msk.ru> writes:

> 20.03.2024 03:32, Richard Henderson :
>
>> Richard Henderson (3):
>>        target/hppa: Fix assemble_16 insns for wide mode
>>        target/hppa: Fix assemble_11a insns for wide mode
>>        target/hppa: Fix assemble_12a insns for wide mode
>> Sven Schnelle (6):
>>        target/hppa: ldcw,s uses static shift of 3
>>        target/hppa: fix shrp for wide mode
>>        target/hppa: fix access_id check
>>        target/hppa: exit tb on flush cache instructions
>>        target/hppa: mask privilege bits in mfia
>>        target/hppa: fix do_stdby_e()
>
> Is it all -stable material (when appropriate)?

I'd say yes.
Helge Deller March 21, 2024, 6:32 p.m. UTC | #4
On 3/21/24 19:25, Sven Schnelle wrote:
> Michael Tokarev <mjt@tls.msk.ru> writes:
>
>> 20.03.2024 03:32, Richard Henderson :
>>
>>> Richard Henderson (3):
>>>         target/hppa: Fix assemble_16 insns for wide mode
>>>         target/hppa: Fix assemble_11a insns for wide mode
>>>         target/hppa: Fix assemble_12a insns for wide mode
>>> Sven Schnelle (6):
>>>         target/hppa: ldcw,s uses static shift of 3
>>>         target/hppa: fix shrp for wide mode
>>>         target/hppa: fix access_id check
>>>         target/hppa: exit tb on flush cache instructions
>>>         target/hppa: mask privilege bits in mfia
>>>         target/hppa: fix do_stdby_e()
>>
>> Is it all -stable material (when appropriate)?
>
> I'd say yes.

Yes.

Helge
Michael Tokarev March 22, 2024, 4:48 a.m. UTC | #5
21.03.2024 21:32, Helge Deller wrote:
> On 3/21/24 19:25, Sven Schnelle wrote:
>> Michael Tokarev <mjt@tls.msk.ru> writes:
>>
>>> 20.03.2024 03:32, Richard Henderson :
>>>
>>>> Richard Henderson (3):
>>>>         target/hppa: Fix assemble_16 insns for wide mode
>>>>         target/hppa: Fix assemble_11a insns for wide mode
>>>>         target/hppa: Fix assemble_12a insns for wide mode
>>>> Sven Schnelle (6):
>>>>         target/hppa: ldcw,s uses static shift of 3
>>>>         target/hppa: fix shrp for wide mode
>>>>         target/hppa: fix access_id check
>>>>         target/hppa: exit tb on flush cache instructions
>>>>         target/hppa: mask privilege bits in mfia
>>>>         target/hppa: fix do_stdby_e()
>>>
>>> Is it all -stable material (when appropriate)?
>>
>> I'd say yes.
> 
> Yes.

Picked all 9 for stable-8.2.

And none for stable-7.2.  There, just one of them applies.

I understand most of them can be applied still (it is just adding
new lines here and there, the same lines needs to be added to 7.2
but there, context is missing so every patch needs manual applying,
which I'm not feeling confident doing.  If anything of that is
really good to have in 7.2 (which has de-facto become an LTS series),
please re-spin it on top of stable-7.2 branch and send the result
to qemu-stable@.

Thanks,

/mjt
Richard Henderson March 22, 2024, 5:36 p.m. UTC | #6
On 3/21/24 18:48, Michael Tokarev wrote:
> 21.03.2024 21:32, Helge Deller wrote:
>> On 3/21/24 19:25, Sven Schnelle wrote:
>>> Michael Tokarev <mjt@tls.msk.ru> writes:
>>>
>>>> 20.03.2024 03:32, Richard Henderson :
>>>>
>>>>> Richard Henderson (3):
>>>>>         target/hppa: Fix assemble_16 insns for wide mode
>>>>>         target/hppa: Fix assemble_11a insns for wide mode
>>>>>         target/hppa: Fix assemble_12a insns for wide mode
>>>>> Sven Schnelle (6):
>>>>>         target/hppa: ldcw,s uses static shift of 3
>>>>>         target/hppa: fix shrp for wide mode
>>>>>         target/hppa: fix access_id check
>>>>>         target/hppa: exit tb on flush cache instructions
>>>>>         target/hppa: mask privilege bits in mfia
>>>>>         target/hppa: fix do_stdby_e()
>>>>
>>>> Is it all -stable material (when appropriate)?
>>>
>>> I'd say yes.
>>
>> Yes.
> 
> Picked all 9 for stable-8.2.
> 
> And none for stable-7.2.  There, just one of them applies.
> 
> I understand most of them can be applied still (it is just adding
> new lines here and there, the same lines needs to be added to 7.2
> but there, context is missing so every patch needs manual applying,
> which I'm not feeling confident doing.  If anything of that is
> really good to have in 7.2 (which has de-facto become an LTS series),
> please re-spin it on top of stable-7.2 branch and send the result
> to qemu-stable@.

This is all for hppa64 support, which was not present in 7.2.

r~