| Message ID | 20240221060153.3924-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | leds: mlxreg: fix a kernel-doc warning | expand |
On Tue, 20 Feb 2024, Randy Dunlap wrote: Would you mind being more descriptive in your subject lines please? It's common for people (me included) to find subject lines a reliable way to search through Git history and these types of descriptions are likely to cause duplication. Thanks. > Drop one struct description to fix a kernel-doc warning: > > drivers/leds/leds-mlxreg.c:42: warning: Excess struct member 'led_data' description in 'mlxreg_led_data' > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Vadim Pasternak <vadimp@nvidia.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Lee Jones <lee@kernel.org> > Cc: linux-leds@vger.kernel.org > --- > drivers/leds/leds-mlxreg.c | 1 - > 1 file changed, 1 deletion(-) > > diff -- a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c > --- a/drivers/leds/leds-mlxreg.c > +++ b/drivers/leds/leds-mlxreg.c > @@ -29,7 +29,6 @@ > * @data: led configuration data; > * @led_cdev: led class data; > * @base_color: base led color (other colors have constant offset from base); > - * @led_data: led data; > * @data_parent: pointer to private device control data of parent; > * @led_cdev_name: class device name > */
On Fri, 23 Feb 2024, Lee Jones wrote: > On Tue, 20 Feb 2024, Randy Dunlap wrote: > > Would you mind being more descriptive in your subject lines please? > > It's common for people (me included) to find subject lines a reliable > way to search through Git history and these types of descriptions are > likely to cause duplication. Also if you push them in a set, they're easier to apply.
Hi, On 2/23/24 03:01, Lee Jones wrote: > On Fri, 23 Feb 2024, Lee Jones wrote: > >> On Tue, 20 Feb 2024, Randy Dunlap wrote: >> >> Would you mind being more descriptive in your subject lines please? Will do. >> It's common for people (me included) to find subject lines a reliable >> way to search through Git history and these types of descriptions are >> likely to cause duplication. > > Also if you push them in a set, they're easier to apply. Do you mean a git tree or a patch series? I'll be glad to change the 3 patches to a patch series. Thanks.
diff -- a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c --- a/drivers/leds/leds-mlxreg.c +++ b/drivers/leds/leds-mlxreg.c @@ -29,7 +29,6 @@ * @data: led configuration data; * @led_cdev: led class data; * @base_color: base led color (other colors have constant offset from base); - * @led_data: led data; * @data_parent: pointer to private device control data of parent; * @led_cdev_name: class device name */
Drop one struct description to fix a kernel-doc warning: drivers/leds/leds-mlxreg.c:42: warning: Excess struct member 'led_data' description in 'mlxreg_led_data' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Vadim Pasternak <vadimp@nvidia.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Lee Jones <lee@kernel.org> Cc: linux-leds@vger.kernel.org --- drivers/leds/leds-mlxreg.c | 1 - 1 file changed, 1 deletion(-)