diff mbox series

ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CVA

Message ID 20240130095700.165544-1-nicolas.haye@proton.me
State Accepted
Commit ca3afc2806046f626a1518f160a564b90f141f95
Headers show
Series ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CVA | expand

Commit Message

Nicolas Haye Jan. 30, 2024, 9:57 a.m. UTC 
From: n1coh <nicolas.haye@groupegaillard.fr>

Like many b1502 models,
the b1502CVA keyboard doesn't work because of an ACPI DSDT table that describes IRQ 1
as ActiveLow while the kernel overrides it to Edge_High.

Signed-off-by: Nicolas Haye <nicolas.haye@proton.me>
---
 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Rafael J. Wysocki Feb. 12, 2024, 1:38 p.m. UTC | #1 
On Tue, Jan 30, 2024 at 10:57 AM Nicolas Haye <nicolas.haye@proton.me> wrote:
>
> From: n1coh <nicolas.haye@groupegaillard.fr>

Why did you add this line?  It is actively confusing, because the
From: field in your message header matches the S-o-b below.

> Like many b1502 models,
> the b1502CVA keyboard doesn't work because of an ACPI DSDT table that describes IRQ 1
> as ActiveLow while the kernel overrides it to Edge_High.
>
> Signed-off-by: Nicolas Haye <nicolas.haye@proton.me>
> ---
>  drivers/acpi/resource.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index dacad1d846c0..65ce43ecfa8c 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -468,6 +468,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "B1502CGA"),
>                 },
>         },
> +        {
> +                /* Asus ExpertBook B1502CVA */
> +                .matches = {
> +                        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                        DMI_MATCH(DMI_BOARD_NAME, "B1502CVA"),
> +                },
> +        },
>         {
>                 /* Asus ExpertBook B2402CBA */
>                 .matches = {
> --

Applied as 6.9 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index dacad1d846c0..65ce43ecfa8c 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -468,6 +468,13 @@  static const struct dmi_system_id irq1_level_low_skip_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "B1502CGA"),
 		},
 	},
+        {
+                /* Asus ExpertBook B1502CVA */
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+                        DMI_MATCH(DMI_BOARD_NAME, "B1502CVA"),
+                },
+        },
 	{
 		/* Asus ExpertBook B2402CBA */
 		.matches = {