[v3,0/2] media: i2c: Add support for GC08A3 sensor

This series adds YAML DT binding and V4L2 sub-device driver for Galaxycore's
GC08A3 8-megapixel 10-bit RAW CMOS 1/4" sensor, with an MIPI CSI-2 image data
interface and the I2C control bus.

The driver is implemented with V4L2 framework.
 - Async registered as a V4L2 sub-device.
 - As the first component of camera system including Seninf, ISP pipeline.
 - A media entity that provides one source pad in common.
 - Used in camera features on ChromeOS application.

Also this driver supports following features:
 - manual exposure and analog gain control support
 - vertical blanking control support
 - test pattern support
 - media controller support
 - runtime PM support
 - support resolution: 3264x2448@30fps, 1920x1080@60fps

Previous versions of this patch-set can be found here:
v2: https://lore.kernel.org/linux-media/20231207052016.25954-1-zhi.mao@mediatek.com/
v1: https://lore.kernel.org/linux-media/20231123115104.32094-1-zhi.mao@mediatek.com/

This series is based on linux-next, tag: next-20240108
Changes in v3:
- dts-binding files：
-- rename enable-gpio to reset-gpio.
-- remove "status","clock-names" & "clock-frequency" useless infomatin in dts-binding files.
-- remove the modifcation in "vendor-prefixes.yaml" as key words “galaxycore” has been added.

- gc08a sensor driver：
-- rename enable-gpio to reset-gpio in sensor driver
-- remove reset-gpio pull low in start of function：power_on()
-- fix some indentation code style issue in sensor driver probe function
-- remove some dev_info() print log function and some none C style comments in sensor driver
-- remove system suspend/resume operations and implement runtime PM support
-- remove .g_volatile_ctrl() and .try_ctrl() implementations
-- revome g_register/s_register functions
-- remove "mutex" cntrol and use subdev active state
-- remove "fmt&crop" variable in sensor driver and let subdev active state to store them
-- use v4l2-cci api to read/write sensor register
-- remove some dependencies & selection infomation in Kconfig, as they are handled in the VIDEO_CAMERA_SENSOR menu
-- remove .try_ctrl callback function
-- remobe "streaming == enable" in start_stream function
-- use an exact match method in enum_frame_interval() function
-- add "V4L2_SUBDEV_FL_HAS_EVENTS" for sd.flags in probe() function

Thanks

Zhi Mao (2):
  media: dt-bindings: media: i2c: Document GC08A3 bindings
  media: i2c: Add GC08A3 image sensor driver

 .../bindings/media/i2c/galaxycore,gc08a3.yaml |  112 ++
 drivers/media/i2c/Kconfig                     |   10 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/gc08a3.c                    | 1467 +++++++++++++++++
 4 files changed, 1590 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
 create mode 100644 drivers/media/i2c/gc08a3.c

Hi Krzysztof,

Thanks for your review.


On Tue, 2024-01-09 at 10:24 +0100, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 09/01/2024 03:27, Zhi Mao wrote:
> > Add YAML device tree binding for GC08A3 CMOS image sensor,
> > and the relevant MAINTAINERS entries.
> > 
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> 
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> Subject: only one "media", so:
> media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor
> 
fixed in patch:v4.

> > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> 
> ...
> 
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        sensor0@31 {
> 
> sensor@31
> 
> With above fixed:
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
fixed in patch:v4. 

> Before you reply, fix your email client. It's impossible to read your
> responses.
> 
> Best regards,
> Krzysztof
>