mbox series

[net,0/5] selftests: net: More small fixes

Message ID 20240131140848.360618-1-bpoirier@nvidia.com
Headers show
Series selftests: net: More small fixes | expand

Message

Benjamin Poirier Jan. 31, 2024, 2:08 p.m. UTC 
Some small fixes for net selftests which follow from these recent commits:
dd2d40acdbb2 ("selftests: bonding: Add more missing config options")
49078c1b80b6 ("selftests: forwarding: Remove executable bits from lib.sh")

Benjamin Poirier (5):
  selftests: team: Add missing config options
  selftests: bonding: Check initial state
  selftests: net: Remove executable bits from library scripts
  selftests: net: List helper scripts in TEST_FILES Makefile variable
  selftests: forwarding: List helper scripts in TEST_FILES Makefile
    variable

 .../testing/selftests/drivers/net/bonding/lag_lib.sh  | 11 +++++++++++
 tools/testing/selftests/drivers/net/team/config       |  4 +++-
 tools/testing/selftests/net/Makefile                  |  5 ++---
 tools/testing/selftests/net/forwarding/Makefile       |  2 +-
 tools/testing/selftests/net/net_helper.sh             |  0
 tools/testing/selftests/net/setup_loopback.sh         |  0
 6 files changed, 17 insertions(+), 5 deletions(-)
 mode change 100755 => 100644 tools/testing/selftests/net/net_helper.sh
 mode change 100755 => 100644 tools/testing/selftests/net/setup_loopback.sh

Comments

Jakub Kicinski Feb. 1, 2024, 1:15 a.m. UTC | #1 
On Wed, 31 Jan 2024 09:08:43 -0500 Benjamin Poirier wrote:
> Some small fixes for net selftests which follow from these recent commits:
> dd2d40acdbb2 ("selftests: bonding: Add more missing config options")
> 49078c1b80b6 ("selftests: forwarding: Remove executable bits from lib.sh")

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Not so great that the team test was passing even tho it lacks 
so many configs...

TAP version 13
1..1
# timeout set to 45
# selftests: drivers/net/team: dev_addr_lists.sh
# Error: Unknown device type.
# Error: Unknown device type.
# This program is not intended to be run as root.
[   17.601119] team0: Mode changed to "loadbalance"
# RTNETLINK answers: Operation not supported
# TEST: team cleanup mode lacp                                        [ OK ]
ok 1 selftests: drivers/net/team: dev_addr_lists.sh

:(
patchwork-bot+netdevbpf@kernel.org Feb. 1, 2024, 4:40 p.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 31 Jan 2024 09:08:43 -0500 you wrote:
> Some small fixes for net selftests which follow from these recent commits:
> dd2d40acdbb2 ("selftests: bonding: Add more missing config options")
> 49078c1b80b6 ("selftests: forwarding: Remove executable bits from lib.sh")
> 
> Benjamin Poirier (5):
>   selftests: team: Add missing config options
>   selftests: bonding: Check initial state
>   selftests: net: Remove executable bits from library scripts
>   selftests: net: List helper scripts in TEST_FILES Makefile variable
>   selftests: forwarding: List helper scripts in TEST_FILES Makefile
>     variable
> 
> [...]

Here is the summary with links:
  - [net,1/5] selftests: team: Add missing config options
    https://git.kernel.org/netdev/net/c/7b6fb3050d8f
  - [net,2/5] selftests: bonding: Check initial state
    https://git.kernel.org/netdev/net/c/8cc063ae1b3d
  - [net,3/5] selftests: net: Remove executable bits from library scripts
    (no matching commit)
  - [net,4/5] selftests: net: List helper scripts in TEST_FILES Makefile variable
    https://git.kernel.org/netdev/net/c/06efafd8608d
  - [net,5/5] selftests: forwarding: List helper scripts in TEST_FILES Makefile variable
    https://git.kernel.org/netdev/net/c/96cd5ac4c0e6

You are awesome, thank you!