| Message ID | 20231205184503.79769-2-Nikolai.Kondrashov@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: Introduce V: entry for tests | expand |
On 12/5/23 20:55, Joe Perches wrote: > On Tue, 2023-12-05 at 20:02 +0200, Nikolai Kondrashov wrote: >> Do not die, but only warn when scripts/get_maintainer.pl is asked to >> retrieve information about a missing file. >> >> This allows scripts/checkpatch.pl to query MAINTAINERS while processing >> patches which are removing files. > > Why is this useful? > > Give a for-instance example please. Does the example I provided make sense, Joe? Would my solution be adequate, or would you like to have another? Thank you. Nick
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 16d8ac6005b6f..37901c2298388 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -541,7 +541,11 @@ foreach my $file (@ARGV) { if ((-d $file)) { $file =~ s@([^/])$@$1/@; } elsif (!(-f $file)) { - die "$P: file '${file}' not found\n"; + if ($from_filename) { + warn "$P: file '${file}' not found\n"; + } else { + die "$P: file '${file}' not found\n"; + } } } if ($from_filename && (vcs_exists() && !vcs_file_exists($file))) {
Do not die, but only warn when scripts/get_maintainer.pl is asked to retrieve information about a missing file. This allows scripts/checkpatch.pl to query MAINTAINERS while processing patches which are removing files. Signed-off-by: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com> --- scripts/get_maintainer.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)