Message ID | 20240122203528.672004-1-kuba@kernel.org |
---|---|
State | Accepted |
Commit | 04fe7c5029cbdbcdb28917f09a958d939a8f19f7 |
Headers | show |
Series | [net] selftests: fill in some missing configs for net | expand |
On Mon, Jan 22, 2024 at 12:35 PM -08, Jakub Kicinski wrote: > We are missing a lot of config options from net selftests, > it seems: > > tun/tap: CONFIG_TUN, CONFIG_MACVLAN, CONFIG_MACVTAP > fib_tests: CONFIG_NET_SCH_FQ_CODEL > l2tp: CONFIG_L2TP, CONFIG_L2TP_V3, CONFIG_L2TP_IP, CONFIG_L2TP_ETH > sctp-vrf: CONFIG_INET_DIAG > txtimestamp: CONFIG_NET_CLS_U32 > vxlan_mdb: CONFIG_BRIDGE_VLAN_FILTERING > gre_gso: CONFIG_NET_IPGRE_DEMUX, CONFIG_IP_GRE, CONFIG_IPV6_GRE > srv6_end_dt*_l3vpn: CONFIG_IPV6_SEG6_LWTUNNEL > ip_local_port_range: CONFIG_MPTCP > fib_test: CONFIG_NET_CLS_BASIC > rtnetlink: CONFIG_MACSEC, CONFIG_NET_SCH_HTB, CONFIG_XFRM_INTERFACE > CONFIG_NET_IPGRE, CONFIG_BONDING > fib_nexthops: CONFIG_MPLS, CONFIG_MPLS_ROUTING > vxlan_mdb: CONFIG_NET_ACT_GACT > tls: CONFIG_TLS, CONFIG_CRYPTO_CHACHA20POLY1305 > psample: CONFIG_PSAMPLE > fcnal: CONFIG_TCP_MD5SIG > > Try to add them in a semi-alphabetical order. > > Fixes: 62199e3f1658 ("selftests: net: Add VXLAN MDB test") > Fixes: c12e0d5f267d ("self-tests: introduce self-tests for RPS default mask") > Fixes: ae5439658cce ("selftests/net: Cover the IP_LOCAL_PORT_RANGE socket option") MPTCP coverage is a recent (Dec '23) addition. I must have missed it. Fortunately we don't need to backport that far. Should be: Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > -- > These are not all the options we're missing. Since the merge window > is over I may not have the time to dig into it myself :( > > Adding Fixes tag for 3 semi-random commits which I think missed things. > The full list would be very long. > > CC: shuah@kernel.org > CC: razor@blackwall.org > CC: idosch@nvidia.com > CC: horms@kernel.org > CC: jakub@cloudflare.com > CC: kuniyu@amazon.com > CC: linux-kselftest@vger.kernel.org > --- > tools/testing/selftests/net/config | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config > index 8da562a9ae87..19ff75051660 100644 > --- a/tools/testing/selftests/net/config > +++ b/tools/testing/selftests/net/config > @@ -1,5 +1,6 @@ > CONFIG_USER_NS=y > CONFIG_NET_NS=y > +CONFIG_BONDING=m > CONFIG_BPF_SYSCALL=y > CONFIG_TEST_BPF=m > CONFIG_NUMA=y > @@ -14,9 +15,13 @@ CONFIG_VETH=y > CONFIG_NET_IPVTI=y > CONFIG_IPV6_VTI=y > CONFIG_DUMMY=y > +CONFIG_BRIDGE_VLAN_FILTERING=y > CONFIG_BRIDGE=y > +CONFIG_CRYPTO_CHACHA20POLY1305=m > CONFIG_VLAN_8021Q=y > CONFIG_IFB=y > +CONFIG_INET_DIAG=y > +CONFIG_IP_GRE=m > CONFIG_NETFILTER=y > CONFIG_NETFILTER_ADVANCED=y > CONFIG_NF_CONNTRACK=m > @@ -25,15 +30,36 @@ CONFIG_IP6_NF_IPTABLES=m > CONFIG_IP_NF_IPTABLES=m > CONFIG_IP6_NF_NAT=m > CONFIG_IP_NF_NAT=m > +CONFIG_IPV6_GRE=m > +CONFIG_IPV6_SEG6_LWTUNNEL=y > +CONFIG_L2TP_ETH=m > +CONFIG_L2TP_IP=m > +CONFIG_L2TP=m > +CONFIG_L2TP_V3=y > +CONFIG_MACSEC=m > +CONFIG_MACVLAN=y > +CONFIG_MACVTAP=y > +CONFIG_MPLS=y > +CONFIG_MPTCP=y > CONFIG_NF_TABLES=m > CONFIG_NF_TABLES_IPV6=y > CONFIG_NF_TABLES_IPV4=y > CONFIG_NFT_NAT=m > +CONFIG_NET_ACT_GACT=m > +CONFIG_NET_CLS_BASIC=m > +CONFIG_NET_CLS_U32=m > +CONFIG_NET_IPGRE_DEMUX=m > +CONFIG_NET_IPGRE=m > +CONFIG_NET_SCH_FQ_CODEL=m > +CONFIG_NET_SCH_HTB=m > CONFIG_NET_SCH_FQ=m > CONFIG_NET_SCH_ETF=m > CONFIG_NET_SCH_NETEM=y > +CONFIG_PSAMPLE=m > +CONFIG_TCP_MD5SIG=y > CONFIG_TEST_BLACKHOLE_DEV=m > CONFIG_KALLSYMS=y > +CONFIG_TLS=m > CONFIG_TRACEPOINTS=y > CONFIG_NET_DROP_MONITOR=m > CONFIG_NETDEVSIM=m > @@ -48,7 +74,9 @@ CONFIG_BAREUDP=m > CONFIG_IPV6_IOAM6_LWTUNNEL=y > CONFIG_CRYPTO_SM4_GENERIC=y > CONFIG_AMT=m > +CONFIG_TUN=y > CONFIG_VXLAN=m > CONFIG_IP_SCTP=m > CONFIG_NETFILTER_XT_MATCH_POLICY=m > CONFIG_CRYPTO_ARIA=y > +CONFIG_XFRM_INTERFACE=m
On Tue, 23 Jan 2024 14:55:59 +0100 Jakub Sitnicki wrote: > > Fixes: ae5439658cce ("selftests/net: Cover the IP_LOCAL_PORT_RANGE socket option") > > MPTCP coverage is a recent (Dec '23) addition. I must have missed it. > > Fortunately we don't need to backport that far. Should be: > > Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE") Thanks! I'll swap when applying, if you don't mind :)
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 22 Jan 2024 12:35:28 -0800 you wrote: > We are missing a lot of config options from net selftests, > it seems: > > tun/tap: CONFIG_TUN, CONFIG_MACVLAN, CONFIG_MACVTAP > fib_tests: CONFIG_NET_SCH_FQ_CODEL > l2tp: CONFIG_L2TP, CONFIG_L2TP_V3, CONFIG_L2TP_IP, CONFIG_L2TP_ETH > sctp-vrf: CONFIG_INET_DIAG > txtimestamp: CONFIG_NET_CLS_U32 > vxlan_mdb: CONFIG_BRIDGE_VLAN_FILTERING > gre_gso: CONFIG_NET_IPGRE_DEMUX, CONFIG_IP_GRE, CONFIG_IPV6_GRE > srv6_end_dt*_l3vpn: CONFIG_IPV6_SEG6_LWTUNNEL > ip_local_port_range: CONFIG_MPTCP > fib_test: CONFIG_NET_CLS_BASIC > rtnetlink: CONFIG_MACSEC, CONFIG_NET_SCH_HTB, CONFIG_XFRM_INTERFACE > CONFIG_NET_IPGRE, CONFIG_BONDING > fib_nexthops: CONFIG_MPLS, CONFIG_MPLS_ROUTING > vxlan_mdb: CONFIG_NET_ACT_GACT > tls: CONFIG_TLS, CONFIG_CRYPTO_CHACHA20POLY1305 > psample: CONFIG_PSAMPLE > fcnal: CONFIG_TCP_MD5SIG > > [...] Here is the summary with links: - [net] selftests: fill in some missing configs for net https://git.kernel.org/netdev/net/c/04fe7c5029cb You are awesome, thank you!
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index 8da562a9ae87..19ff75051660 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -1,5 +1,6 @@ CONFIG_USER_NS=y CONFIG_NET_NS=y +CONFIG_BONDING=m CONFIG_BPF_SYSCALL=y CONFIG_TEST_BPF=m CONFIG_NUMA=y @@ -14,9 +15,13 @@ CONFIG_VETH=y CONFIG_NET_IPVTI=y CONFIG_IPV6_VTI=y CONFIG_DUMMY=y +CONFIG_BRIDGE_VLAN_FILTERING=y CONFIG_BRIDGE=y +CONFIG_CRYPTO_CHACHA20POLY1305=m CONFIG_VLAN_8021Q=y CONFIG_IFB=y +CONFIG_INET_DIAG=y +CONFIG_IP_GRE=m CONFIG_NETFILTER=y CONFIG_NETFILTER_ADVANCED=y CONFIG_NF_CONNTRACK=m @@ -25,15 +30,36 @@ CONFIG_IP6_NF_IPTABLES=m CONFIG_IP_NF_IPTABLES=m CONFIG_IP6_NF_NAT=m CONFIG_IP_NF_NAT=m +CONFIG_IPV6_GRE=m +CONFIG_IPV6_SEG6_LWTUNNEL=y +CONFIG_L2TP_ETH=m +CONFIG_L2TP_IP=m +CONFIG_L2TP=m +CONFIG_L2TP_V3=y +CONFIG_MACSEC=m +CONFIG_MACVLAN=y +CONFIG_MACVTAP=y +CONFIG_MPLS=y +CONFIG_MPTCP=y CONFIG_NF_TABLES=m CONFIG_NF_TABLES_IPV6=y CONFIG_NF_TABLES_IPV4=y CONFIG_NFT_NAT=m +CONFIG_NET_ACT_GACT=m +CONFIG_NET_CLS_BASIC=m +CONFIG_NET_CLS_U32=m +CONFIG_NET_IPGRE_DEMUX=m +CONFIG_NET_IPGRE=m +CONFIG_NET_SCH_FQ_CODEL=m +CONFIG_NET_SCH_HTB=m CONFIG_NET_SCH_FQ=m CONFIG_NET_SCH_ETF=m CONFIG_NET_SCH_NETEM=y +CONFIG_PSAMPLE=m +CONFIG_TCP_MD5SIG=y CONFIG_TEST_BLACKHOLE_DEV=m CONFIG_KALLSYMS=y +CONFIG_TLS=m CONFIG_TRACEPOINTS=y CONFIG_NET_DROP_MONITOR=m CONFIG_NETDEVSIM=m @@ -48,7 +74,9 @@ CONFIG_BAREUDP=m CONFIG_IPV6_IOAM6_LWTUNNEL=y CONFIG_CRYPTO_SM4_GENERIC=y CONFIG_AMT=m +CONFIG_TUN=y CONFIG_VXLAN=m CONFIG_IP_SCTP=m CONFIG_NETFILTER_XT_MATCH_POLICY=m CONFIG_CRYPTO_ARIA=y +CONFIG_XFRM_INTERFACE=m
We are missing a lot of config options from net selftests, it seems: tun/tap: CONFIG_TUN, CONFIG_MACVLAN, CONFIG_MACVTAP fib_tests: CONFIG_NET_SCH_FQ_CODEL l2tp: CONFIG_L2TP, CONFIG_L2TP_V3, CONFIG_L2TP_IP, CONFIG_L2TP_ETH sctp-vrf: CONFIG_INET_DIAG txtimestamp: CONFIG_NET_CLS_U32 vxlan_mdb: CONFIG_BRIDGE_VLAN_FILTERING gre_gso: CONFIG_NET_IPGRE_DEMUX, CONFIG_IP_GRE, CONFIG_IPV6_GRE srv6_end_dt*_l3vpn: CONFIG_IPV6_SEG6_LWTUNNEL ip_local_port_range: CONFIG_MPTCP fib_test: CONFIG_NET_CLS_BASIC rtnetlink: CONFIG_MACSEC, CONFIG_NET_SCH_HTB, CONFIG_XFRM_INTERFACE CONFIG_NET_IPGRE, CONFIG_BONDING fib_nexthops: CONFIG_MPLS, CONFIG_MPLS_ROUTING vxlan_mdb: CONFIG_NET_ACT_GACT tls: CONFIG_TLS, CONFIG_CRYPTO_CHACHA20POLY1305 psample: CONFIG_PSAMPLE fcnal: CONFIG_TCP_MD5SIG Try to add them in a semi-alphabetical order. Fixes: 62199e3f1658 ("selftests: net: Add VXLAN MDB test") Fixes: c12e0d5f267d ("self-tests: introduce self-tests for RPS default mask") Fixes: ae5439658cce ("selftests/net: Cover the IP_LOCAL_PORT_RANGE socket option") Signed-off-by: Jakub Kicinski <kuba@kernel.org> -- These are not all the options we're missing. Since the merge window is over I may not have the time to dig into it myself :( Adding Fixes tag for 3 semi-random commits which I think missed things. The full list would be very long. CC: shuah@kernel.org CC: razor@blackwall.org CC: idosch@nvidia.com CC: horms@kernel.org CC: jakub@cloudflare.com CC: kuniyu@amazon.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/net/config | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)