| Message ID | 20240119071936.3481439-1-xu.yang_2@nxp.com |
|---|---|
| State | Accepted |
| Commit | 6687155ffc6671514f2ef874ac8be41d9d131918 |
| Headers | show |
| Series | [v4,1/7] dt-bindings: usb: usbmisc-imx: add fsl,imx8ulp-usbmisc compatible | expand |
On 19/01/2024 08:19, Xu Yang wrote: > Add "fsl,imx8ulp-usbmisc" compatible. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 19/01/2024 08:19, Xu Yang wrote: > Change reg, interrupts, clock and clock-names as common properties and add > restrictions on them for different compatibles. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v4: > - new patch since v3's discussion > - split the reg, interrupts, clock and clock-names properties into > common part and device-specific > --- > .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 118 +++++++++++++++--- > 1 file changed, 102 insertions(+), 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > index b7e664f7395b..78e30ca0a8ca 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > @@ -73,22 +73,10 @@ properties: > - nuvoton,npcm845-udc > - const: nuvoton,npcm750-udc > > - reg: > - minItems: 1 > - maxItems: 2 > - > - interrupts: > - minItems: 1 > - maxItems: 2 > - > - clocks: > - minItems: 1 > - maxItems: 3 > - > - clock-names: > - minItems: 1 > - maxItems: 3 Why all these are gone? They are supposed to be here. Your if:then: only customizes them. > - > + reg: true > + interrupts: true > + clocks: true > + clock-names: true No. These are not booleans on other variants. > dr_mode: true > > power-domains: > @@ -412,6 +400,104 @@ allOf: > samsung,picophy-pre-emp-curr-control: false > samsung,picophy-dc-vol-level-adjust: false > > + - if: > + properties: > + compatible: > + oneOf: > + - items: > + - const: fsl,imx27-usb No, the syntax you need is contains:. Look at existing code - there is no single binding with oneOf: in if: block. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml index 2d3589d284b2..0a6e7ac1b37e 100644 --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml @@ -33,6 +33,7 @@ properties: - fsl,imx7ulp-usbmisc - fsl,imx8mm-usbmisc - fsl,imx8mn-usbmisc + - fsl,imx8ulp-usbmisc - const: fsl,imx7d-usbmisc - const: fsl,imx6q-usbmisc - items:
Add "fsl,imx8ulp-usbmisc" compatible. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v3: - new patch due to missed this little one Changes in v4: - no changes --- Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 1 + 1 file changed, 1 insertion(+)