| Message ID | 20240126-x13s-touchscreen-v2-2-5374ccc9e10d@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp-x13s: Enable touchscreen | expand |
On Fri, Jan 26, 2024 at 08:41:39AM -0800, Bjorn Andersson wrote: > The failing read-test in __i2c_hid_core_probe() determines that there's > nothing connected at the documented address of the touchscreen. > > Introduce the 5ms after-power and 200ms after-reset delays found in the > ACPI tables. Also wire up the reset-gpio, for good measure. Please amend the commit message so that it reflects the discussion we just had (e.g. wiring up the reset-gpio is not just for good measure). Johan
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index def3976bd5bb..33731b95ad51 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -620,7 +620,6 @@ &i2c4 { status = "okay"; - /* FIXME: verify */ touchscreen@10 { compatible = "hid-over-i2c"; reg = <0x10>; @@ -630,6 +629,11 @@ touchscreen@10 { vdd-supply = <&vreg_misc_3p3>; vddl-supply = <&vreg_s10b>; + reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>; + + post-power-on-delay-ms = <5>; + post-reset-deassert-delay-ms = <200>; + pinctrl-names = "default"; pinctrl-0 = <&ts0_default>; }; @@ -1450,7 +1454,6 @@ int-n-pins { reset-n-pins { pins = "gpio99"; function = "gpio"; - output-high; drive-strength = <16>; }; };
The failing read-test in __i2c_hid_core_probe() determines that there's nothing connected at the documented address of the touchscreen. Introduce the 5ms after-power and 200ms after-reset delays found in the ACPI tables. Also wire up the reset-gpio, for good measure. Fixes: 32c231385ed4 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree") Tested-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)