| Message ID | 20240125163408.1595135-10-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Clean up includes | expand |
On 25/1/24 17:34, Peter Maydell wrote: > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git riscv target/riscv/*.[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/riscv/vector_internals.h | 1 - > target/riscv/vector_internals.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Thu, Jan 25, 2024 at 04:34:07PM +0000, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:07 +0000 > From: Peter Maydell <peter.maydell@linaro.org> > Subject: [PATCH 09/10] riscv: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git riscv target/riscv/*.[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/riscv/vector_internals.h | 1 - > target/riscv/vector_internals.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Zhao Liu <zhao1.liu@intel.com> > > diff --git a/target/riscv/vector_internals.h b/target/riscv/vector_internals.h > index 8133111e5f6..842765f6c16 100644 > --- a/target/riscv/vector_internals.h > +++ b/target/riscv/vector_internals.h > @@ -19,7 +19,6 @@ > #ifndef TARGET_RISCV_VECTOR_INTERNALS_H > #define TARGET_RISCV_VECTOR_INTERNALS_H > > -#include "qemu/osdep.h" > #include "qemu/bitops.h" > #include "cpu.h" > #include "tcg/tcg-gvec-desc.h" > diff --git a/target/riscv/vector_internals.c b/target/riscv/vector_internals.c > index 9cf5c17cdea..12f5964fbbe 100644 > --- a/target/riscv/vector_internals.c > +++ b/target/riscv/vector_internals.c > @@ -16,6 +16,7 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include "qemu/osdep.h" > #include "vector_internals.h" > > /* set agnostic elements to 1s */ > -- > 2.34.1 > >
On Fri, Jan 26, 2024 at 2:35 AM Peter Maydell <peter.maydell@linaro.org> wrote: > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git riscv target/riscv/*.[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > target/riscv/vector_internals.h | 1 - > target/riscv/vector_internals.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/vector_internals.h b/target/riscv/vector_internals.h > index 8133111e5f6..842765f6c16 100644 > --- a/target/riscv/vector_internals.h > +++ b/target/riscv/vector_internals.h > @@ -19,7 +19,6 @@ > #ifndef TARGET_RISCV_VECTOR_INTERNALS_H > #define TARGET_RISCV_VECTOR_INTERNALS_H > > -#include "qemu/osdep.h" > #include "qemu/bitops.h" > #include "cpu.h" > #include "tcg/tcg-gvec-desc.h" > diff --git a/target/riscv/vector_internals.c b/target/riscv/vector_internals.c > index 9cf5c17cdea..12f5964fbbe 100644 > --- a/target/riscv/vector_internals.c > +++ b/target/riscv/vector_internals.c > @@ -16,6 +16,7 @@ > * this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#include "qemu/osdep.h" > #include "vector_internals.h" > > /* set agnostic elements to 1s */ > -- > 2.34.1 > >
diff --git a/target/riscv/vector_internals.h b/target/riscv/vector_internals.h index 8133111e5f6..842765f6c16 100644 --- a/target/riscv/vector_internals.h +++ b/target/riscv/vector_internals.h @@ -19,7 +19,6 @@ #ifndef TARGET_RISCV_VECTOR_INTERNALS_H #define TARGET_RISCV_VECTOR_INTERNALS_H -#include "qemu/osdep.h" #include "qemu/bitops.h" #include "cpu.h" #include "tcg/tcg-gvec-desc.h" diff --git a/target/riscv/vector_internals.c b/target/riscv/vector_internals.c index 9cf5c17cdea..12f5964fbbe 100644 --- a/target/riscv/vector_internals.c +++ b/target/riscv/vector_internals.c @@ -16,6 +16,7 @@ * this program. If not, see <http://www.gnu.org/licenses/>. */ +#include "qemu/osdep.h" #include "vector_internals.h" /* set agnostic elements to 1s */
This commit was created with scripts/clean-includes: ./scripts/clean-includes --git riscv target/riscv/*.[ch] All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/riscv/vector_internals.h | 1 - target/riscv/vector_internals.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)