| Message ID | 20240116-usbc-phy-vls-clamp-v1-4-73b2da7691c5@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | phy: qcom: qmp-usbc: properly handle the clamping register | expand |
On 1/16/24 02:08, Dmitry Baryshkov wrote: > The USB3 PHY on the MSM8998 platform doesn't have built-in > PCS_MISC_CLAMP_ENABLE register. Instead clamping is handled separately > via the register in the TCSR space. Declare corresponding register. > > Fixes: 026dad8f5873 ("arm64: dts: qcom: msm8998: Add USB-related nodes") > Cc: Jeffrey Hugo <quic_jhugo@quicinc.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 2793cc22d381..e21e5693ba1e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -2174,6 +2174,8 @@ usb3phy: phy@c010000 { > reset-names = "phy", > "phy_phy"; > > + qcom,tcsr-reg = <&tcsr_regs_1 0x6b244>; This leaks outside the syscon. Konrad
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 2793cc22d381..e21e5693ba1e 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -2174,6 +2174,8 @@ usb3phy: phy@c010000 { reset-names = "phy", "phy_phy"; + qcom,tcsr-reg = <&tcsr_regs_1 0x6b244>; + status = "disabled"; };
The USB3 PHY on the MSM8998 platform doesn't have built-in PCS_MISC_CLAMP_ENABLE register. Instead clamping is handled separately via the register in the TCSR space. Declare corresponding register. Fixes: 026dad8f5873 ("arm64: dts: qcom: msm8998: Add USB-related nodes") Cc: Jeffrey Hugo <quic_jhugo@quicinc.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 ++ 1 file changed, 2 insertions(+)