| Message ID | 20240104183118.779778-3-wse@tuxedocomputers.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i8042: Add forcenorestore quirk to leave controller | expand |
Hi, On 1/4/24 19:31, Werner Sembach wrote: > The old quirk combination sometimes cause a laggy keyboard after boot. With > the new quirk the initial issue of an unresponsive keyboard after s3 resume > is also fixed, but it doesn't have the negative side effect of the > sometimes laggy keyboard. > > Signed-off-by: Werner Sembach <wse@tuxedocomputers.com> > Cc: stable@vger.kernel.org Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/input/serio/i8042-acpipnpio.h | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h > index 10ec4534e5e14..e631a26394e92 100644 > --- a/drivers/input/serio/i8042-acpipnpio.h > +++ b/drivers/input/serio/i8042-acpipnpio.h > @@ -1142,18 +1142,10 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = { > SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > }, > { > - /* > - * Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS makes > - * the keyboard very laggy for ~5 seconds after boot and > - * sometimes also after resume. > - * However both are required for the keyboard to not fail > - * completely sometimes after boot or resume. > - */ > .matches = { > DMI_MATCH(DMI_BOARD_NAME, "N150CU"), > }, > - .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > - SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + .driver_data = (void *)(SERIO_QUIRK_FORCENORESTORE) > }, > { > .matches = {
On Thu, Jan 04, 2024 at 07:31:18PM +0100, Werner Sembach wrote: > The old quirk combination sometimes cause a laggy keyboard after boot. With > the new quirk the initial issue of an unresponsive keyboard after s3 resume > is also fixed, but it doesn't have the negative side effect of the > sometimes laggy keyboard. > > Signed-off-by: Werner Sembach <wse@tuxedocomputers.com> > Cc: stable@vger.kernel.org Applied, thank you.
diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h index 10ec4534e5e14..e631a26394e92 100644 --- a/drivers/input/serio/i8042-acpipnpio.h +++ b/drivers/input/serio/i8042-acpipnpio.h @@ -1142,18 +1142,10 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = { SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) }, { - /* - * Setting SERIO_QUIRK_NOMUX or SERIO_QUIRK_RESET_ALWAYS makes - * the keyboard very laggy for ~5 seconds after boot and - * sometimes also after resume. - * However both are required for the keyboard to not fail - * completely sometimes after boot or resume. - */ .matches = { DMI_MATCH(DMI_BOARD_NAME, "N150CU"), }, - .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | - SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) + .driver_data = (void *)(SERIO_QUIRK_FORCENORESTORE) }, { .matches = {
The old quirk combination sometimes cause a laggy keyboard after boot. With the new quirk the initial issue of an unresponsive keyboard after s3 resume is also fixed, but it doesn't have the negative side effect of the sometimes laggy keyboard. Signed-off-by: Werner Sembach <wse@tuxedocomputers.com> Cc: stable@vger.kernel.org --- drivers/input/serio/i8042-acpipnpio.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)