mbox series

[0/3] wifi: ath: replace ENOTSUPP with EOPNOTSUPP

Message ID 20240103041220.3082014-1-quic_periyasa@quicinc.com
Headers show
Series wifi: ath: replace ENOTSUPP with EOPNOTSUPP | expand

Message

Karthikeyan Periyasamy Jan. 3, 2024, 4:12 a.m. UTC 
ENOTSUPP is not a standard error code, don't use it. Replace with
EOPNOTSUPP instead.

No functional changes, compile tested only.

Karthikeyan Periyasamy (3):
  wifi: ath12k: replace ENOTSUPP with EOPNOTSUPP
  wifi: ath11k: replace ENOTSUPP with EOPNOTSUPP
  wifi: ath10k: replace ENOTSUPP with EOPNOTSUPP

 drivers/net/wireless/ath/ath10k/core.c    |  4 ++--
 drivers/net/wireless/ath/ath10k/htt.c     |  4 +++-
 drivers/net/wireless/ath/ath10k/mac.c     |  6 +++---
 drivers/net/wireless/ath/ath10k/pci.c     | 10 +++++-----
 drivers/net/wireless/ath/ath10k/wmi-tlv.c |  7 ++++---
 drivers/net/wireless/ath/ath10k/wmi.c     | 12 ++++++------
 drivers/net/wireless/ath/ath11k/dp_tx.c   |  6 +++---
 drivers/net/wireless/ath/ath11k/hal_rx.c  |  4 ++--
 drivers/net/wireless/ath/ath12k/dp_tx.c   |  6 +++---
 drivers/net/wireless/ath/ath12k/hal_rx.c  |  4 ++--
 drivers/net/wireless/ath/ath12k/mac.c     | 10 +++++-----
 11 files changed, 38 insertions(+), 35 deletions(-)


base-commit: 2cd4e3f91f264926a6b11df948417b74d52ca9b9

Comments

Jeff Johnson Jan. 3, 2024, 4:23 p.m. UTC | #1 
On 1/2/2024 8:12 PM, Karthikeyan Periyasamy wrote:
> ENOTSUPP is not a standard error code, don't use it. Replace with
> EOPNOTSUPP instead.
> 
> No functional changes, compile tested only.
> 
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Karthikeyan Periyasamy Jan. 4, 2024, 3:03 a.m. UTC | #2 
On 1/3/2024 10:06 PM, Jeff Johnson wrote:
> On 1/2/2024 8:12 PM, Karthikeyan Periyasamy wrote:
>> ENOTSUPP is not a standard error code, don't use it. Replace with
>> EOPNOTSUPP instead.
>>
>> No functional changes, compile tested only.
>>
>> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
>> ---
>> diff --git a/drivers/net/wireless/ath/ath10k/htt.c b/drivers/net/wireless/ath/ath10k/htt.c
>> index 907e1e13871a..3835c5cc07f9 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt.c
>> @@ -2,6 +2,8 @@
>>   /*
>>    * Copyright (c) 2005-2011 Atheros Communications Inc.
>>    * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
>> + * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
> You are not working on behalf of The Linux Foundation so you should not
> be adding or modifying Linux Foundation copyrights

Sure


>> + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> And this should only have 2024 since there were not any Qualcomm changes
> in 2021-2023

Sure


>> diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> index 0ce08e9a0a3d..9a1889599729 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> @@ -3,6 +3,7 @@
>>    * Copyright (c) 2005-2011 Atheros Communications Inc.
>>    * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
>>    * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
> Again this should only have 2024


Will address in the next version of the patch


Thanks,

Karthikeyan