| Message ID | 20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-0-abacaa63a961@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp: Add CAMSS core dtsi support | expand |
On 03/01/2024 17:54, Rob Herring wrote: > On Wed, Jan 03, 2024 at 09:40:02AM +0000, Bryan O'Donoghue wrote: >> On 03/01/2024 07:40, Krzysztof Kozlowski wrote: >>> On 03/01/2024 03:18, Bryan O'Donoghue wrote: >>>> Add bindings for qcom,sc8280xp-camss in order to support the camera >>>> subsystem for sc8280xp as found in the Lenovo x13s Laptop. >>>> >>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++++ >>>> 1 file changed, 512 insertions(+) >>>> >>> >>> This patch fails, as pointed out by Robot. >>> >>> Best regards, >>> Krzysztof >>> >>> >> >> Ah its in Bjorn's 6.8 clock pull tree. >> >> I will repost when it hits -next > > How is that helpful? It will still fail, and the media maintainers still > can't apply this. If you work on linux-next, you'd better be > aware of and explain the dependencies. > > Rob Well, it actually is in -next as at the time I posted this patch https://git.codelinaro.org/bryan.odonoghue/kernel/-/blob/linux-next-24-01-02-sc8280xp-camss-core-dtsi/include/dt-bindings/clock/qcom,sc8280xp-camcc.h per the branch referenced in the cover letter https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi Looking at the name of the branch for your bot 20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-1-abacaa63a961@linaro.org Does this branch name in the bot output "linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1" imply it built from the branch I referenced in the cover letter "linux-next-24-01-02-sc8280xp-camss-core-dtsi" ? Am I getting the base of the build right ? https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-1-abacaa63a961@linaro.org/ If not - what is the base of the build ? --- bod
On 04/01/2024 12:33, Bryan O'Donoghue wrote: > On 03/01/2024 17:54, Rob Herring wrote: >> On Wed, Jan 03, 2024 at 09:40:02AM +0000, Bryan O'Donoghue wrote: >>> On 03/01/2024 07:40, Krzysztof Kozlowski wrote: >>>> On 03/01/2024 03:18, Bryan O'Donoghue wrote: >>>>> Add bindings for qcom,sc8280xp-camss in order to support the camera >>>>> subsystem for sc8280xp as found in the Lenovo x13s Laptop. >>>>> >>>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> --- >>>>> .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++++ >>>>> 1 file changed, 512 insertions(+) >>>>> >>>> >>>> This patch fails, as pointed out by Robot. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>>> >>> >>> Ah its in Bjorn's 6.8 clock pull tree. >>> >>> I will repost when it hits -next >> >> How is that helpful? It will still fail, and the media maintainers still >> can't apply this. If you work on linux-next, you'd better be >> aware of and explain the dependencies. >> >> Rob > > Well, it actually is in -next as at the time I posted this patch linux-next is not a tree of one maintainer. Maintainer's cannot base their trees on linux-next. > > https://git.codelinaro.org/bryan.odonoghue/kernel/-/blob/linux-next-24-01-02-sc8280xp-camss-core-dtsi/include/dt-bindings/clock/qcom,sc8280xp-camcc.h > > per the branch referenced in the cover letter Cover letter does not say anything about this depending on the patch in linux-next or in any other tree. > > https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi > > Looking at the name of the branch for your bot > > 20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-1-abacaa63a961@linaro.org That's your message ID. > > Does this branch name in the bot output > "linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1" imply it built from > the branch I referenced in the cover letter > "linux-next-24-01-02-sc8280xp-camss-core-dtsi" ? > > Am I getting the base of the build right ? > > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-1-abacaa63a961@linaro.org/ > > If not - what is the base of the build ? master Anyway, the base of the build matters less. The main problem is that you have dependency which is nowhere explained. This cannot go via media tree, because of that dependency. Best regards, Krzysztof
On 03/01/2024 03:18, Bryan O'Donoghue wrote: > This series adds the yaml, CAMSS and CCI dts definitions for the sc8280xp. > > 4 x CCI master busses > 4 x VFE > 4 x VFE Lite > 4 x CSID > 4 x CSIPHY > > Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Bryan O'Donoghue (3): > media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding > arm64: dts: qcom: sc8280xp: camss: Add CCI definitions > arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition > > .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++ > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 563 +++++++++++++++++++++ > 2 files changed, 1075 insertions(+) > --- > base-commit: ab0b3e6ef50d305278b1971891cf1d82ab050b35 BTW, this also does not help, when used on random commit or random tree: $ git show ab0b3e6ef50d305278b1971891cf1d82ab050b35 fatal: bad object ab0b3e6ef50d305278b1971891cf1d82ab050b35 Best regards, Krzysztof
On 04/01/2024 12:40, Krzysztof Kozlowski wrote: >> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-1-abacaa63a961@linaro.org/ >> >> If not - what is the base of the build ? > master > > Anyway, the base of the build matters less. The main problem is that you > have dependency which is nowhere explained. This cannot go via media > tree, because of that dependency. Obvs my mistake I'd have assumed the dts stuff built against -next, clearly not how this works. I'll ensure I spell out the base dep in v2. --- bod
On 04/01/2024 12:42, Krzysztof Kozlowski wrote: > On 03/01/2024 03:18, Bryan O'Donoghue wrote: >> This series adds the yaml, CAMSS and CCI dts definitions for the sc8280xp. >> >> 4 x CCI master busses >> 4 x VFE >> 4 x VFE Lite >> 4 x CSID >> 4 x CSIPHY >> >> Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> Bryan O'Donoghue (3): >> media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding >> arm64: dts: qcom: sc8280xp: camss: Add CCI definitions >> arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition >> >> .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 563 +++++++++++++++++++++ >> 2 files changed, 1075 insertions(+) >> --- >> base-commit: ab0b3e6ef50d305278b1971891cf1d82ab050b35 > > BTW, this also does not help, when used on random commit or random tree: > > $ git show ab0b3e6ef50d305278b1971891cf1d82ab050b35 > fatal: bad object ab0b3e6ef50d305278b1971891cf1d82ab050b35 > > Best regards, > Krzysztof > That's a b4 thing I think, not sure what it uses it for. --- bod
This series adds the yaml, CAMSS and CCI dts definitions for the sc8280xp. 4 x CCI master busses 4 x VFE 4 x VFE Lite 4 x CSID 4 x CSIPHY Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Bryan O'Donoghue (3): media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding arm64: dts: qcom: sc8280xp: camss: Add CCI definitions arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 563 +++++++++++++++++++++ 2 files changed, 1075 insertions(+) --- base-commit: ab0b3e6ef50d305278b1971891cf1d82ab050b35 change-id: 20240102-linux-next-24-01-02-sc8280xp-camss-core-dtsi-2730a5f7ef98 Best regards,