mbox series

[v1,0/2] ARM: dts: at91: gardena-smart-gateway: Use DMA for serial ports

Message ID 20240102161839.702625-1-ezra.buehler@husqvarna.com
Headers show
Series ARM: dts: at91: gardena-smart-gateway: Use DMA for serial ports | expand

Message

Ezra Buehler Jan. 2, 2024, 4:18 p.m. UTC
From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

On our AT91SAM9G25-based GARDENA smart Gateway we have been experiencing
various problems which we were able to trace back to unreliable UART
communication. Enabling DMA for the serial ports resolved these issues.

Ezra Buehler (2):
  ARM: dts: at91: at91sam9x5ek: Use DMA for DBGU serial port
  ARM: dts: at91: gardena-smart-gateway: Use DMA for USART3

 .../boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts    | 2 ++
 arch/arm/boot/dts/microchip/at91sam9x5ek.dtsi                   | 2 ++
 2 files changed, 4 insertions(+)

--
2.39.2

Comments

Nicolas Ferre Jan. 3, 2024, 1:47 p.m. UTC | #1
On 02/01/2024 at 17:18, ezra@easyb.ch wrote:
> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
> 
> The UART controller does not seem to be fast enough to receive data (at
> 115200 baud) without dropping bytes when DMA is disabled.
> 
> This has often been noticed when pasting SSH keys into the serial
> console (ttyS0). Only after multiple tries, the long strings would be
> successfully transferred without missing characters.
> 
> Co-Developed-by: Michael Zimmermann <michael.zimmermann@grandcentrix.net>
> Signed-off-by: Michael Zimmermann <michael.zimmermann@grandcentrix.net>
> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

Fine with me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks for your patch. Best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/microchip/at91sam9x5ek.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91sam9x5ek.dtsi b/arch/arm/boot/dts/microchip/at91sam9x5ek.dtsi
> index 5f4eaa618ab4..9618b8d965b0 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9x5ek.dtsi
> +++ b/arch/arm/boot/dts/microchip/at91sam9x5ek.dtsi
> @@ -39,6 +39,8 @@ &adc0 {
>   };
> 
>   &dbgu {
> +       atmel,use-dma-rx;
> +       atmel,use-dma-tx;
>          status = "okay";
>   };
> 
> --
> 2.39.2
>