| Message ID | 20231223051108.74711-1-kdipendra88@gmail.com |
|---|---|
| State | Accepted |
| Commit | 89354baf8f151d34aab5b7e8f44e719165fa7d73 |
| Headers | show |
| Series | [v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h | expand |
Hi Dipendra, On 12/22/23 21:11, Dipendra Khadka wrote: > codespell reported spelling mistakes in > ia_css_acc_types.h as below: > > ''' > ia_css_acc_types.h:87: cummulative ==> cumulative > ia_css_acc_types.h:411: descibes ==> describes > ''' > > This patch fixes these spelling mistakes. > > Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> This patch is an improvement so it could be merged as is IMO. But... > --- > v2: > - Previously only corrected spelling mistake reported by checkpatch.pl. > - All spelling mistakes reported by codespell are fixed. > v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/ > > drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h > index d6e52b4971d6..1dc2085ecd61 100644 > --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h > +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h > @@ -84,7 +84,7 @@ struct ia_css_blob_info { > memory_offsets; /** offset wrt hdr in bytes */ > u32 prog_name_offset; /** offset wrt hdr in bytes */ > u32 size; /** Size of blob */ > - u32 padding_size; /** total cummulative of bytes added due to section alignment */ > + u32 padding_size; /** total cumulative of bytes added due to section alignment */ I apologize for not looking at your v1 patch carefully. The comment above would be much better as /** total accumulation of bytes added due to section alignment */ And if the maintainer(s) want to take it as is: Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > u32 icache_source; /** Position of icache in blob */ > u32 icache_size; /** Size of icache section */ > u32 icache_padding;/** bytes added due to icache section alignment */ > @@ -408,7 +408,7 @@ struct ia_css_acc_sp { > }; > > /* Acceleration firmware descriptor. > - * This descriptor descibes either SP code (stand-alone), or > + * This descriptor describes either SP code (stand-alone), or > * ISP code (a separate pipeline stage). > */ > struct ia_css_acc_fw_hdr {
On 12/22/23 21:29, Dipendra Khadka wrote: > Hi Randy, > > On Sat, 23 Dec 2023 at 11:03, Randy Dunlap <rdunlap@infradead.org> wrote: >> >> Hi Dipendra, >> >> On 12/22/23 21:11, Dipendra Khadka wrote: >>> codespell reported spelling mistakes in >>> ia_css_acc_types.h as below: >>> >>> ''' >>> ia_css_acc_types.h:87: cummulative ==> cumulative >>> ia_css_acc_types.h:411: descibes ==> describes >>> ''' >>> >>> This patch fixes these spelling mistakes. >>> >>> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> >> >> This patch is an improvement so it could be merged as is IMO. >> But... >> >>> --- >>> v2: >>> - Previously only corrected spelling mistake reported by checkpatch.pl. >>> - All spelling mistakes reported by codespell are fixed. >>> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/ >>> >>> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h >>> index d6e52b4971d6..1dc2085ecd61 100644 >>> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h >>> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h >>> @@ -84,7 +84,7 @@ struct ia_css_blob_info { >>> memory_offsets; /** offset wrt hdr in bytes */ >>> u32 prog_name_offset; /** offset wrt hdr in bytes */ >>> u32 size; /** Size of blob */ >>> - u32 padding_size; /** total cummulative of bytes added due to section alignment */ >>> + u32 padding_size; /** total cumulative of bytes added due to section alignment */ >> >> I apologize for not looking at your v1 patch carefully. >> The comment above would be much better as >> >> /** total accumulation of bytes added due to section alignment */ >> > > So, would you like me to change "cummulative" to accumulation or > should I wait what other maintainer(s) would say? > I think just wait for a few days to see what other review comments there are. > >> And if the maintainer(s) want to take it as is: >> Acked-by: Randy Dunlap <rdunlap@infradead.org> >> >> Thanks. >> >> >>> u32 icache_source; /** Position of icache in blob */ >>> u32 icache_size; /** Size of icache section */ >>> u32 icache_padding;/** bytes added due to icache section alignment */ >>> @@ -408,7 +408,7 @@ struct ia_css_acc_sp { >>> }; >>> >>> /* Acceleration firmware descriptor. >>> - * This descriptor descibes either SP code (stand-alone), or >>> + * This descriptor describes either SP code (stand-alone), or >>> * ISP code (a separate pipeline stage). >>> */ >>> struct ia_css_acc_fw_hdr { >> >> -- >> #Randy >> https://people.kernel.org/tglx/notes-about-netiquette >> https://subspace.kernel.org/etiquette.html
Hi, On Sat, 23 Dec 2023 at 16:10, Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 12/23/23 06:18, Randy Dunlap wrote: > > Hi Dipendra, > > > > On 12/22/23 21:11, Dipendra Khadka wrote: > >> codespell reported spelling mistakes in > >> ia_css_acc_types.h as below: > >> > >> ''' > >> ia_css_acc_types.h:87: cummulative ==> cumulative > >> ia_css_acc_types.h:411: descibes ==> describes > >> ''' > >> > >> This patch fixes these spelling mistakes. > >> > >> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> > > > > This patch is an improvement so it could be merged as is IMO. > > But... > > > >> --- > >> v2: > >> - Previously only corrected spelling mistake reported by checkpatch.pl. > >> - All spelling mistakes reported by codespell are fixed. > >> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/ > >> > >> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h > >> index d6e52b4971d6..1dc2085ecd61 100644 > >> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h > >> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h > >> @@ -84,7 +84,7 @@ struct ia_css_blob_info { > >> memory_offsets; /** offset wrt hdr in bytes */ > >> u32 prog_name_offset; /** offset wrt hdr in bytes */ > >> u32 size; /** Size of blob */ > >> - u32 padding_size; /** total cummulative of bytes added due to section alignment */ > >> + u32 padding_size; /** total cumulative of bytes added due to section alignment */ > > > > I apologize for not looking at your v1 patch carefully. > > The comment above would be much better as > > > > /** total accumulation of bytes added due to section alignment */ > > I agree that that is better. Dipendra can you please send a v3 > using the new text suggested by Randy ? Sure,let me send a v3 with the new text suggested by Randy. Regards, Dipendra > > Regards, > > Hans > > > > >> u32 icache_source; /** Position of icache in blob */ > >> u32 icache_size; /** Size of icache section */ > >> u32 icache_padding;/** bytes added due to icache section alignment */ > >> @@ -408,7 +408,7 @@ struct ia_css_acc_sp { > >> }; > >> > >> /* Acceleration firmware descriptor. > >> - * This descriptor descibes either SP code (stand-alone), or > >> + * This descriptor describes either SP code (stand-alone), or > >> * ISP code (a separate pipeline stage). > >> */ > >> struct ia_css_acc_fw_hdr { > > >
diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h index d6e52b4971d6..1dc2085ecd61 100644 --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h @@ -84,7 +84,7 @@ struct ia_css_blob_info { memory_offsets; /** offset wrt hdr in bytes */ u32 prog_name_offset; /** offset wrt hdr in bytes */ u32 size; /** Size of blob */ - u32 padding_size; /** total cummulative of bytes added due to section alignment */ + u32 padding_size; /** total cumulative of bytes added due to section alignment */ u32 icache_source; /** Position of icache in blob */ u32 icache_size; /** Size of icache section */ u32 icache_padding;/** bytes added due to icache section alignment */ @@ -408,7 +408,7 @@ struct ia_css_acc_sp { }; /* Acceleration firmware descriptor. - * This descriptor descibes either SP code (stand-alone), or + * This descriptor describes either SP code (stand-alone), or * ISP code (a separate pipeline stage). */ struct ia_css_acc_fw_hdr {
codespell reported spelling mistakes in ia_css_acc_types.h as below: ''' ia_css_acc_types.h:87: cummulative ==> cumulative ia_css_acc_types.h:411: descibes ==> describes ''' This patch fixes these spelling mistakes. Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> --- v2: - Previously only corrected spelling mistake reported by checkpatch.pl. - All spelling mistakes reported by codespell are fixed. v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/ drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)