| Message ID | 20231222-pinetab2-v1-1-e148a7f61bd1@mecka.net |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: rockchip: Pine64 pinetab2 support | expand |
On 22/12/2023 12:05, Manuel Traut wrote: > Add bindings for the BOE TH101MB31IG002-28A LCD panel. It is > used e.g. in the Pine64 Pinetab2 and PinetabV. > > Signed-off-by: Manuel Traut <manut@mecka.net> > --- > + > +maintainers: > + - Manuel Traut <manut@mecka.net> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + enum: > + # BOE TH101MB31IG002-28A 10.1" WXGA TFT LCD panel > + - boe,th101mb31ig002-28a > + > + reg: reg: true > + description: the virtual channel number of a DSI peripheral > + > + backlight: : true > + description: phandle of the backlight device attached to the panel Because there is really no need to repeat obvious. > + > + enable-gpios: > + description: a GPIO spec for the enable pin Ditto > + > + power-supply: > + description: core voltage supply Ditto > + > + And drop redundant blank lines. > + ports: true Hm, why ports? From where did you copy it? > + rotation: true > + > +required: > + - compatible > + - reg > + - enable-gpios > + - power-supply > + > +additionalProperties: false > + > +examples: > + - | > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "boe,th101mb31ig002-28a"; > + reg = <0>; > + backlight = <&backlight_lcd0>; > + enable-gpios = <&pio 45 0>; Use define for GPIO flag. Best regards, Krzysztof
On Friday, 22 December 2023 12:05:41 CET Manuel Traut wrote:
> +title: BOE TH101MB31IG002-28A Pine64 Pinetab2 DSI Display Panel
s/Pine64 Pinetab2 // ?
It is used by the PT2 but I assume it's a 'standalone' panel?
diff --git a/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml b/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml new file mode 100644 index 000000000000..a8a5e1b4439b --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/boe,th101mb31ig002-28a.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/boe,th101mb31ig002-28a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BOE TH101MB31IG002-28A Pine64 Pinetab2 DSI Display Panel + +maintainers: + - Manuel Traut <manut@mecka.net> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + enum: + # BOE TH101MB31IG002-28A 10.1" WXGA TFT LCD panel + - boe,th101mb31ig002-28a + + reg: + description: the virtual channel number of a DSI peripheral + + backlight: + description: phandle of the backlight device attached to the panel + + enable-gpios: + description: a GPIO spec for the enable pin + + power-supply: + description: core voltage supply + + + ports: true + rotation: true + +required: + - compatible + - reg + - enable-gpios + - power-supply + +additionalProperties: false + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "boe,th101mb31ig002-28a"; + reg = <0>; + backlight = <&backlight_lcd0>; + enable-gpios = <&pio 45 0>; + rotation = <90>; + power-supply = <&vcc_3v3>; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + panel_in_dsi: endpoint@0 { + reg = <0>; + remote-endpoint = <&dsi0_out_con>; + }; + }; + }; + }; + }; + +...
Add bindings for the BOE TH101MB31IG002-28A LCD panel. It is used e.g. in the Pine64 Pinetab2 and PinetabV. Signed-off-by: Manuel Traut <manut@mecka.net> --- .../display/panel/boe,th101mb31ig002-28a.yaml | 73 ++++++++++++++++++++++ 1 file changed, 73 insertions(+)