diff mbox series

[1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE

Message ID 20231212100044.26466-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 03b024887da4db8041fb64438cb02e55a409f007
Headers show
Series [1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE | expand

Commit Message

Krzysztof Kozlowski Dec. 12, 2023, 10 a.m. UTC
Binding marks several devices as compatible with IPQ4019 QCE.  They have
different number of clocks, thus the fallback does not define the
clock constraints per variant and each specific compatible should have
its clocks in if:then: section.

Add missing clocks description for IPQ9574 QCE.

Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Dec. 14, 2023, 9:40 p.m. UTC | #1
On Tue, 12 Dec 2023 11:00:43 +0100, Krzysztof Kozlowski wrote:
> Binding marks several devices as compatible with IPQ4019 QCE.  They have
> different number of clocks, thus the fallback does not define the
> clock constraints per variant and each specific compatible should have
> its clocks in if:then: section.
> 
> Add missing clocks description for IPQ9574 QCE.
> 
> Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Rob Herring Dec. 14, 2023, 9:40 p.m. UTC | #2
On Tue, 12 Dec 2023 11:00:44 +0100, Krzysztof Kozlowski wrote:
> All devices compatible with SM8150 QCE (so SM8250 and newer) do not have
> clock inputs (clocks are handled by secure firmware), so explicitly
> disallow the clocks in the bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/crypto/qcom-qce.yaml          | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Herbert Xu Dec. 22, 2023, 4:36 a.m. UTC | #3
On Tue, Dec 12, 2023 at 11:00:43AM +0100, Krzysztof Kozlowski wrote:
> Binding marks several devices as compatible with IPQ4019 QCE.  They have
> different number of clocks, thus the fallback does not define the
> clock constraints per variant and each specific compatible should have
> its clocks in if:then: section.
> 
> Add missing clocks description for IPQ9574 QCE.
> 
> Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> index eeb8a956d7cb..6435708da202 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> @@ -97,6 +97,7 @@ allOf:
>                - qcom,crypto-v5.4
>                - qcom,ipq6018-qce
>                - qcom,ipq8074-qce
> +              - qcom,ipq9574-qce
>                - qcom,msm8996-qce
>                - qcom,sdm845-qce
>      then:
> -- 
> 2.34.1

All applied.  Thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index eeb8a956d7cb..6435708da202 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -97,6 +97,7 @@  allOf:
               - qcom,crypto-v5.4
               - qcom,ipq6018-qce
               - qcom,ipq8074-qce
+              - qcom,ipq9574-qce
               - qcom,msm8996-qce
               - qcom,sdm845-qce
     then: