diff mbox series

[v2,1/5] arm64: dts: imx8ulp: add usb nodes

Message ID 20231218085456.3962720-1-xu.yang_2@nxp.com
State Superseded
Headers show
Series [v2,1/5] arm64: dts: imx8ulp: add usb nodes | expand

Commit Message

Xu Yang Dec. 18, 2023, 8:54 a.m. UTC 
Add USB nodes on i.MX8ULP platform which has 2 USB controllers.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v2:
 - no changes
---
 arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 64 ++++++++++++++++++++++
 1 file changed, 64 insertions(+)

Comments

Fabio Estevam Dec. 18, 2023, 10:16 a.m. UTC | #1 
On Mon, Dec 18, 2023 at 5:49 AM Xu Yang <xu.yang_2@nxp.com> wrote:

> +
> +       ptn5150_1: typec@1d {
> +               compatible = "nxp,ptn5150";
> +               reg = <0x1d>;
> +               int-gpios = <&gpiof 3 IRQ_TYPE_EDGE_FALLING>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_typec1>;
> +               status = "disabled";

Why disabled?

No connector and no port properties. Please run dt-schema check
against linux-next.

> +       };
> +
> +       ptn5150_2: typec@3d {
> +               compatible = "nxp,ptn5150";
> +               reg = <0x3d>;
> +               int-gpios = <&gpiof 5 IRQ_TYPE_EDGE_FALLING>;
> +                       pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_typec2>;
> +               status = "disabled";

Same here.
Xu Yang Dec. 19, 2023, 7:35 a.m. UTC | #2 
Hi Fabio,

> 
> On Mon, Dec 18, 2023 at 5:49 AM Xu Yang <xu.yang_2@nxp.com> wrote:
> 
> > +
> > +       ptn5150_1: typec@1d {
> > +               compatible = "nxp,ptn5150";
> > +               reg = <0x1d>;
> > +               int-gpios = <&gpiof 3 IRQ_TYPE_EDGE_FALLING>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_typec1>;
> > +               status = "disabled";
> 
> Why disabled?

As we talked before,  I just present these nodes here since the
i.MX8ULP board does have these chips. And I think the above 
information is enough to let people know and use it if they
really want. In most of the cases, it's not needed. 

> 
> No connector and no port properties. Please run dt-schema check
> against linux-next.

The ptn5150 driver doesn't have any relation with typec subsystem. As
Jun said, it uses extcon. 

Also I have run dt-schema check, no warnings.

Thanks,
Xu Yang
	
> 
> > +       };
> > +
> > +       ptn5150_2: typec@3d {
> > +               compatible = "nxp,ptn5150";
> > +               reg = <0x3d>;
> > +               int-gpios = <&gpiof 5 IRQ_TYPE_EDGE_FALLING>;
> > +                       pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_typec2>;
> > +               status = "disabled";
> 
> Same here.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
index c4a0082f30d3..ead1f57e08ef 100644
--- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
@@ -28,6 +28,8 @@  aliases {
 		serial1 = &lpuart5;
 		serial2 = &lpuart6;
 		serial3 = &lpuart7;
+		usbphy0 = &usbphy1;
+		usbphy1 = &usbphy2;
 	};
 
 	cpus {
@@ -472,6 +474,68 @@  usdhc2: mmc@298f0000 {
 				status = "disabled";
 			};
 
+			usbotg1: usb@29900000 {
+				compatible = "fsl,imx8ulp-usb", "fsl,imx7ulp-usb", "fsl,imx6ul-usb";
+				reg = <0x29900000 0x200>;
+				interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&pcc4 IMX8ULP_CLK_USB0>;
+				power-domains = <&scmi_devpd IMX8ULP_PD_USB0>;
+				phys = <&usbphy1>;
+				fsl,usbmisc = <&usbmisc1 0>;
+				ahb-burst-config = <0x0>;
+				tx-burst-size-dword = <0x8>;
+				rx-burst-size-dword = <0x8>;
+				status = "disabled";
+			};
+
+			usbmisc1: usbmisc@29900200 {
+				compatible = "fsl,imx8ulp-usbmisc", "fsl,imx7d-usbmisc",
+						"fsl,imx6q-usbmisc";
+				#index-cells = <1>;
+				reg = <0x29900200 0x200>;
+				status = "disabled";
+			};
+
+			usbphy1: usb-phy@29910000 {
+				compatible = "fsl,imx8ulp-usbphy", "fsl,imx7ulp-usbphy";
+				reg = <0x29910000 0x10000>;
+				interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&pcc4 IMX8ULP_CLK_USB0_PHY>;
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+
+			usbotg2: usb@29920000 {
+				compatible = "fsl,imx8ulp-usb", "fsl,imx7ulp-usb", "fsl,imx6ul-usb";
+				reg = <0x29920000 0x200>;
+				interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&pcc4 IMX8ULP_CLK_USB1>;
+				power-domains = <&scmi_devpd IMX8ULP_PD_USDHC2_USB1>;
+				phys = <&usbphy2>;
+				fsl,usbmisc = <&usbmisc2 0>;
+				ahb-burst-config = <0x0>;
+				tx-burst-size-dword = <0x8>;
+				rx-burst-size-dword = <0x8>;
+				status = "disabled";
+			};
+
+			usbmisc2: usbmisc@29920200 {
+				compatible = "fsl,imx8ulp-usbmisc", "fsl,imx7d-usbmisc",
+						"fsl,imx6q-usbmisc";
+				#index-cells = <1>;
+				reg = <0x29920200 0x200>;
+				status = "disabled";
+			};
+
+			usbphy2: usb-phy@29930000 {
+				compatible = "fsl,imx8ulp-usbphy", "fsl,imx7ulp-usbphy";
+				reg = <0x29930000 0x10000>;
+				interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&pcc4 IMX8ULP_CLK_USB1_PHY>;
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+
 			fec: ethernet@29950000 {
 				compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec", "fsl,imx6q-fec";
 				reg = <0x29950000 0x10000>;