| Message ID | 20231106144335.v2.9.Ie30c1d3f780666f6906fd2fd7c437632c229d987@changeid |
|---|---|
| State | Accepted |
| Commit | eaea10a2d10898cd5e999a7b25af42c888b1df73 |
| Headers | show |
| Series | [v2,1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered | expand |
Hi Doug, > Hi, > > On Mon, Nov 6, 2023 at 2:44 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog > > bark interrupt edge triggered"), the Qualcomm watchdog timer's bark > > interrupt should be configured as edge triggered. > > > > Update the example in the bindings. > > > > Fixes: 7c631cdff391 ("dt-bindings: watchdog: qcom-wdt: allow interrupts") > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > (no changes since v1) > > > > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I saw Bjorn landed all of the dts patches from this series but it > looks like the bindings patch got left behind. Anyone want to claim it > for their tree, or Ack it saying that you'd prefer for it to go > through someone else's tree? I assume Krzysztof's Ack means he's not > intending for it to go through the DT tree and Bjorn doesn't seem to > intend for it to go through the Qualcomm tree. Guenter/Wim: it feels > like this could go in the watchdog tree? I picked it up in the watchdog tree. Kind regards, Wim.
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 5046dfa55f13..681d1efbaf2f 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -121,7 +121,7 @@ examples: compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; reg = <0x17c10000 0x1000>; clocks = <&sleep_clk>; - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>; timeout-sec = <10>; };
As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Update the example in the bindings. Fixes: 7c631cdff391 ("dt-bindings: watchdog: qcom-wdt: allow interrupts") Reviewed-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- (no changes since v1) Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)