diff mbox series

[v3] dt-bindings: net: wireless: mt76: add interrupts description for MT7986

Message ID 20231215023833.8881-1-chui-hao.chiu@mediatek.com
State New
Headers show
Series [v3] dt-bindings: net: wireless: mt76: add interrupts description for MT7986 | expand

Commit Message

Peter Chiu Dec. 15, 2023, 2:38 a.m. UTC
The mt7986 can support four interrupts to distribute the interrupts
to different CPUs.

Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
---
v2: Change to use description instead of using items.
v3: Change to use items and set different minItems for mediatek,mt7986-wmac
---
 .../bindings/net/wireless/mediatek,mt76.yaml  | 28 +++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Dec. 15, 2023, 8:17 a.m. UTC | #1
On 15/12/2023 03:38, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
> 
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> ---
> v2: Change to use description instead of using items.
> v3: Change to use items and set different minItems for mediatek,mt7986-wmac

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

> ---
>  .../bindings/net/wireless/mediatek,mt76.yaml  | 28 +++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 252207adbc54..58bbddabd388 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -38,7 +38,12 @@ properties:
>        MT7986 should contain 3 regions consys, dcm, and sku, in this order.
>  
>    interrupts:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description: major interrupt for rings
> +      - description: additional interrupt for ring 19
> +      - description: additional interrupt for ring 4
> +      - description: additional interrupt for ring 5


>  
>    power-domains:
>      maxItems: 1
> @@ -213,6 +218,22 @@ properties:
>                      description:
>                        Half-dBm power delta for different numbers of antennas
>  

allOf:

And then please look at example-schema. This should be placed after
required:.

> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - mediatek,mt7986-wmac
> +then:
> +  properties:
> +    interrupts:
> +      minItems: 4
> +else:
> +  properties:
> +    interrupts:
> +      maxItems: 1
> +
> +

Just one blank line.

>  required:
>    - compatible
Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 252207adbc54..58bbddabd388 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -38,7 +38,12 @@  properties:
       MT7986 should contain 3 regions consys, dcm, and sku, in this order.
 
   interrupts:
-    maxItems: 1
+    minItems: 1
+    items:
+      - description: major interrupt for rings
+      - description: additional interrupt for ring 19
+      - description: additional interrupt for ring 4
+      - description: additional interrupt for ring 5
 
   power-domains:
     maxItems: 1
@@ -213,6 +218,22 @@  properties:
                     description:
                       Half-dBm power delta for different numbers of antennas
 
+if:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - mediatek,mt7986-wmac
+then:
+  properties:
+    interrupts:
+      minItems: 4
+else:
+  properties:
+    interrupts:
+      maxItems: 1
+
+
 required:
   - compatible
   - reg
@@ -293,7 +314,10 @@  examples:
         reg = <0x18000000 0x1000000>,
               <0x10003000 0x1000>,
               <0x11d10000 0x1000>;
-        interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>;
+        interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>;
         clocks = <&topckgen 50>,
                  <&topckgen 62>;
         clock-names = "mcu", "ap2conn";