diff mbox series

[v2,07/23] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header

Message ID 20231212123401.37493-8-philmd@linaro.org
State Superseded
Headers show
Series exec: Rework of various headers (user focused) | expand

Commit Message

Philippe Mathieu-Daudé Dec. 12, 2023, 12:33 p.m. UTC 
Nothing in guestfd.c requires "semihosting/uaccess.h" nor "qemu.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 semihosting/guestfd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Anton Johansson Dec. 13, 2023, 10:58 a.m. UTC | #1 
On 12/12/23, Philippe Mathieu-Daudé wrote:
> Nothing in guestfd.c requires "semihosting/uaccess.h" nor "qemu.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  semihosting/guestfd.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c
> index 955c2efbd0..d3241434c5 100644
> --- a/semihosting/guestfd.c
> +++ b/semihosting/guestfd.c
> @@ -12,10 +12,7 @@
>  #include "gdbstub/syscalls.h"
>  #include "semihosting/semihost.h"
>  #include "semihosting/guestfd.h"
> -#ifdef CONFIG_USER_ONLY
> -#include "qemu.h"
> -#else
> -#include "semihosting/uaccess.h"
> +#ifndef CONFIG_USER_ONLY
>  #include CONFIG_DEVICES
>  #endif
>  
> -- 
> 2.41.0
> 

Reviewed-by: Anton Johansson <anjo@rev.ng>
diff mbox series

Patch

diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c
index 955c2efbd0..d3241434c5 100644
--- a/semihosting/guestfd.c
+++ b/semihosting/guestfd.c
@@ -12,10 +12,7 @@ 
 #include "gdbstub/syscalls.h"
 #include "semihosting/semihost.h"
 #include "semihosting/guestfd.h"
-#ifdef CONFIG_USER_ONLY
-#include "qemu.h"
-#else
-#include "semihosting/uaccess.h"
+#ifndef CONFIG_USER_ONLY
 #include CONFIG_DEVICES
 #endif