| Message ID | 20231111094623.12476-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | dc6b5562acbac0285ab3b2dad23930b6434bdfc6 |
| Headers | show |
| Series | arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator | expand |
On 11.11.2023 10:46, Krzysztof Kozlowski wrote: > There is no "panic-indicator" default trigger but a property with that > name: > > qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected) > > Fixes: b5cbd84e499a ("arm64: dts: qcom: qrb5165-rb5: Add onboard LED support") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Sat, Nov 11, 2023 at 10:46:23AM +0100, Krzysztof Kozlowski wrote: > There is no "panic-indicator" default trigger but a property with that > name: > > qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected) > > Fixes: b5cbd84e499a ("arm64: dts: qcom: qrb5165-rb5: Add onboard LED support") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index 3bd0c06e7315..e43f73f1be1b 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -64,8 +64,8 @@ led-user4 { > function = LED_FUNCTION_INDICATOR; > color = <LED_COLOR_ID_GREEN>; > gpios = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "panic-indicator"; > default-state = "off"; > + panic-indicator; > }; > > led-wlan { > -- > 2.34.1 >
On Sat, 11 Nov 2023 10:46:23 +0100, Krzysztof Kozlowski wrote: > There is no "panic-indicator" default trigger but a property with that > name: > > qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected) > > Applied, thanks! [1/1] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator commit: dc6b5562acbac0285ab3b2dad23930b6434bdfc6 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index 3bd0c06e7315..e43f73f1be1b 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -64,8 +64,8 @@ led-user4 { function = LED_FUNCTION_INDICATOR; color = <LED_COLOR_ID_GREEN>; gpios = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "panic-indicator"; default-state = "off"; + panic-indicator; }; led-wlan {
There is no "panic-indicator" default trigger but a property with that name: qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected) Fixes: b5cbd84e499a ("arm64: dts: qcom: qrb5165-rb5: Add onboard LED support") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)