| Message ID | 20231130174114.13122-3-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | 4bddb0cdfad9148a08b2bda7c3d479b1da715929 |
| Headers | show |
| Series | dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix up examples | expand |
On 30/11/2023 18:41, Johan Hovold wrote: > Clean up the examples by adding newline separators, moving 'reg' > properties after 'compatible' and dropping unused labels. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 5 +++-- > .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++---- > 2 files changed, 9 insertions(+), 6 deletions(-) This and previous patch are both trivial cleanups, so probably should be squashed together. Anyway: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Dec 01, 2023 at 09:28:48AM +0100, Krzysztof Kozlowski wrote: > On 30/11/2023 18:41, Johan Hovold wrote: > > Clean up the examples by adding newline separators, moving 'reg' > > properties after 'compatible' and dropping unused labels. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 5 +++-- > > .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++---- > > 2 files changed, 9 insertions(+), 6 deletions(-) > > This and previous patch are both trivial cleanups, so probably should be > squashed together. Anyway: I didn't want to mix too many things in one patch, and as I just mentioned in another reply, I consider the "spmi" parent node name to be more than just a naming cleanup as calling the node "spmi" indicates that these "devices" are SPMI devices themselves, rather than part of an SPMI PMIC. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks again. Johan
diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml index 82f8f25885c0..7541e27704ca 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml @@ -118,9 +118,10 @@ examples: pmic { #address-cells = <1>; #size-cells = <0>; + pm8998_adc: adc@3100 { - reg = <0x3100>; compatible = "qcom,spmi-adc-rev2"; + reg = <0x3100>; #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>; @@ -131,7 +132,7 @@ examples: }; }; - pm8998_adc_tm: adc-tm@3400 { + adc-tm@3400 { compatible = "qcom,spmi-adc-tm-hc"; reg = <0x3400>; interrupts = <0x2 0x34 0x0 IRQ_TYPE_EDGE_RISING>; diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml index 02347cee6c6f..d9d2657287cb 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml @@ -171,9 +171,10 @@ examples: pmic { #address-cells = <1>; #size-cells = <0>; + pm8150b_adc: adc@3100 { - reg = <0x3100>; compatible = "qcom,spmi-adc5"; + reg = <0x3100>; #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>; @@ -187,7 +188,7 @@ examples: }; }; - pm8150b_adc_tm: adc-tm@3500 { + adc-tm@3500 { compatible = "qcom,spmi-adc-tm5"; reg = <0x3500>; interrupts = <0x2 0x35 0x0 IRQ_TYPE_EDGE_RISING>; @@ -212,9 +213,10 @@ examples: pmic { #address-cells = <1>; #size-cells = <0>; + pmk8350_vadc: adc@3100 { - reg = <0x3100>; compatible = "qcom,spmi-adc7"; + reg = <0x3100>; #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>; @@ -235,7 +237,7 @@ examples: }; }; - pmk8350_adc_tm: adc-tm@3400 { + adc-tm@3400 { compatible = "qcom,spmi-adc-tm5-gen2"; reg = <0x3400>; interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
Clean up the examples by adding newline separators, moving 'reg' properties after 'compatible' and dropping unused labels. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 5 +++-- .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++---- 2 files changed, 9 insertions(+), 6 deletions(-)