| Message ID | 20231130-topic-ddr_sleep_stats-v1-0-5981c2e764b6@linaro.org |
|---|---|
| Headers | show |
| Series | Add DDR sleep stats | expand |
On Thu, Nov 30, 2023 at 03:58:21PM +0100, Konrad Dybcio wrote: > The stats can be expanded by poking the Always-On Subsystem through QMP. > Allow passing a QMP handle for configurations that support it. I know Qualcomm likes their opaque acronyms, but how about mentioning what QMP stands for here and in the binding below? Especially since we also have QMP PHYs (Qualcomm Multi PHY?), which I doubt this is related to. > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml > index 96a7f1822022..686a7ef2f48a 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom-stats.yaml > @@ -31,10 +31,24 @@ properties: > reg: > maxItems: 1 > > + qcom,qmp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Reference to the AOSS side-channel message RAM Johan
On 1.12.2023 10:44, Johan Hovold wrote: > On Thu, Nov 30, 2023 at 03:58:21PM +0100, Konrad Dybcio wrote: >> The stats can be expanded by poking the Always-On Subsystem through QMP. >> Allow passing a QMP handle for configurations that support it. > > I know Qualcomm likes their opaque acronyms, but how about mentioning > what QMP stands for here and in the binding below? I'll amend the commit message for v2. > Especially since we also have QMP PHYs (Qualcomm Multi PHY?), which I > doubt this is related to. There's only so many three-letter acronyms that begin with a Q ;) QMP stands for Qualcomm Messaging Protocol, which is a JSON-like way to communicate with the Always-On Subsystem (which is responsible for things such as managing low-power states and general SoC building blocks housekeeping) Konrad
On Thu, 30 Nov 2023 15:58:20 +0100, Konrad Dybcio wrote: > RPMh LPM stats are quite extensive, but we can extract even more data by > poking the AOSS QMP. This series adds DDR stats using this approach, > setting it up on 8280 as an example. > > Applied, thanks! [3/3] arm64: dts: qcom: sc8280xp: Add QMP handle to RPMh stats commit: bcaa71f13cc7160f2d5f9a401e9c58215612f79e Best regards,
RPMh LPM stats are quite extensive, but we can extract even more data by poking the AOSS QMP. This series adds DDR stats using this approach, setting it up on 8280 as an example. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Konrad Dybcio (3): dt-bindings: soc: qcom: stats: Add QMP handle soc: qcom: stats: Add DDR sleep stats arm64: dts: qcom: sc8280xp: Add QMP handle to RPMh stats .../devicetree/bindings/soc/qcom/qcom-stats.yaml | 14 ++ arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + drivers/soc/qcom/qcom_stats.c | 186 ++++++++++++++++++++- 3 files changed, 200 insertions(+), 1 deletion(-) --- base-commit: 1f5c003694fab4b1ba6cbdcc417488b975c088d0 change-id: 20231130-topic-ddr_sleep_stats-d968e2e28083 Best regards,